Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cornucopia & Guilds set icon #527

Merged
merged 3 commits into from
Aug 18, 2024
Merged

Add Cornucopia & Guilds set icon #527

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7408cb9
Add Cornucopia & Guilds set icon
sumpfork Aug 17, 2024
ebc5f56
New Icon for Upgrade Pack
nickv2002 Aug 17, 2024
6770808
Update sets_db.json.gz
nickv2002 Aug 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions card_db_src/sets_db.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
"upgrade"
],
"has_extras": false,
"image": "cornucopia_set.png",
"image": "cornucopia_guilds_set.png",
Copy link
Collaborator

@nickv2002 nickv2002 Aug 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sumpfork I think the 2nd Edition Upgrade Set should get the upgraded icon too.
(I didn't rebuild the sets_db.json.gz because I'm a limited connection but I think the build scripts do that)
Otherwise looks good. Thanks.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I got doit update_languages to work and uploaded that sets_db.json.gz so I think it's all good now.

"set_name": "*cornucopia2ndEditionUpgrade*",
"set_text": "",
"short_name": "Cornucopia",
Expand All @@ -93,7 +93,7 @@
"2",
"latest"
],
"image": "cornucopia_set.png",
"image": "cornucopia_guilds_set.png",
"set_name": "*cornucopiaAndGuilds2ndEdition*",
"set_text": "",
"short_name": "Cornucopia and Guilds",
Expand Down
Binary file modified src/domdiv/card_db/sets_db.json.gz
View file
Open in desktop
Binary file not shown.
Binary file added src/domdiv/images/cornucopia_guilds_set.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading