Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cornucopia & Guilds set icon #527

Merged
merged 3 commits into from
Aug 18, 2024
Merged

Add Cornucopia & Guilds set icon #527

merged 3 commits into from
Aug 18, 2024

Conversation

sumpfork
Copy link
Owner

Closes #520

@sumpfork sumpfork requested a review from nickv2002 August 17, 2024 18:47
@sumpfork sumpfork self-assigned this Aug 17, 2024
Add new Corn/Guilds 2nd edition Upgrade pack
Copy link
Contributor

It seems compiling the card DB on this PR produced changes.
Ideally, please run "doit update-language" yourself on this PR and check in the results.
Otherwise, PR #519 has the necessary (but unreviewed) changes.

"image": "cornucopia_set.png",
"image": "cornucopia_guilds_set.png",
Copy link
Collaborator

@nickv2002 nickv2002 Aug 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sumpfork I think the 2nd Edition Upgrade Set should get the upgraded icon too.
(I didn't rebuild the sets_db.json.gz because I'm a limited connection but I think the build scripts do that)
Otherwise looks good. Thanks.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I got doit update_languages to work and uploaded that sets_db.json.gz so I think it's all good now.

rebuild `sets_db.json.gz` with `doit update_languages`
@sumpfork sumpfork merged commit b8fb136 into master Aug 18, 2024
7 checks passed
@sumpfork sumpfork deleted the corn_guilds_icon branch August 18, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cornucopia/Guilds 2e set icon
2 participants