Request DLSS extensions only when they are supported #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only request DLSS extensions if the loader and driver report that they are supported. This should skip loading DLSS on systems with old drivers or GPUs that are not NVIDIA. While technically all extensions should be validated before launching, I think it is fine to let the application crash if no fallback is provided e.g forcing GL renderer if RT is not possible.
I have not tested this on NVIDIA, hopefully nothing broke. Runs fine on my RDNA2 card now even when compiled with DLSS support.