Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FolioClient for renewing items and canceling holds #795

Merged
merged 5 commits into from
May 10, 2023
Merged

Add FolioClient for renewing items and canceling holds #795

merged 5 commits into from
May 10, 2023

Conversation

jcoyne
Copy link
Contributor

@jcoyne jcoyne commented May 5, 2023 •
edited
Loading

Ref #735 #736

@jcoyne jcoyne changed the title Add FolioClient for renewing items Add FolioClient for renewing items and canceling holds May 5, 2023
@jcoyne jcoyne marked this pull request as ready for review May 10, 2023 16:42
@thatbudakguy
Copy link
Member

could we cherry-pick b6a6eb6 onto this as well? It looks like we were worried about escaping things in these CQL queries, and I think it makes sense to bring in CqlQuery with the client. I don't think we need anything else from #741

@jcoyne
Convert to use faraday-retry
0b9ce17 
So that request can retry if they fail
@jcoyne
Copy link
Contributor Author

jcoyne commented May 10, 2023

@thatbudakguy I cherry-picked the Cql class into this pr and moved to use faraday-retry

thatbudakguy
thatbudakguy approved these changes May 10, 2023
View reviewed changes
Copy link
Member

@thatbudakguy thatbudakguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks!!

@jcoyne jcoyne merged commit 12befe9 into main May 10, 2023
@jcoyne jcoyne deleted the folio_client branch May 10, 2023 21:52
@thatbudakguy thatbudakguy mentioned this pull request Jun 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thatbudakguy thatbudakguy thatbudakguy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcoyne @thatbudakguy @cbeer