Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the mod-patron (edge-patron?)API to cancel a hold #736

Closed
cbeer opened this issue Aug 22, 2022 · 4 comments · Fixed by #829
Closed

Use the mod-patron (edge-patron?)API to cancel a hold #736

cbeer opened this issue Aug 22, 2022 · 4 comments · Fixed by #829
Assignees

Comments

@cbeer
Copy link
Member

cbeer commented Aug 22, 2022

No description provided.

@cbeer cbeer changed the title Use the edge-patron API to cancel a hold Use the mod-patron (edge-patron?)API to cancel a hold Aug 25, 2022
@thatbudakguy thatbudakguy moved this from 📋 Backlog to 🔖 Ready in Searchworks/FOLIO Summer 2022/23 May 5, 2023
@thatbudakguy
Copy link
Member

this ticket is mostly just to confirm the API functions how it says it does and isn't broken.

@jcoyne jcoyne self-assigned this May 5, 2023
@jcoyne jcoyne moved this from 🔖 Ready to 🏗 In progress in Searchworks/FOLIO Summer 2022/23 May 5, 2023
jcoyne added a commit that referenced this issue May 5, 2023
jcoyne added a commit that referenced this issue May 5, 2023
@jcoyne
Copy link
Contributor

jcoyne commented May 15, 2023

It seems to be broken (or the documentation is incorrect)

@thatbudakguy
Copy link
Member

current status:

  • we probably don't want to use edge-patron because it's not installed and that has implications for all patron-related routes
  • it's possible to use mod-circulation to do this, but more investigation is needed to see what behavior the ILS actually exhibits with respect to the request and if it's different from using mod-patron to cancel
  • we don't want to outright destroy requests since staff sometimes examine previous canceled requests for a patron
  • we want to make sure that any workflows tied to cancellations still happen

@jcoyne
Copy link
Contributor

jcoyne commented May 15, 2023

It looks like the FOLIO UI just updates the request for a cancel:

XHR PUT
https://okapi-test.stanford.edu/circulation/requests/39a4ebd1-0137-45ff-a6a2-c256de260840
[HTTP/1.1 204 No Content 5255ms]

	
cancellationAdditionalInformation	"Seems good to cancel."
cancellationReasonId	"b35c8771-04c6-4eb2-a481-b9480563e84c"
cancelledByUserId	"ad914b1b-06fe-5aef-8446-d60b57395f2f"
cancelledDate	"2023-05-15T19:09:00.216Z"
fulfilmentPreference	"Hold Shelf"
id	"39a4ebd1-0137-45ff-a6a2-c256de260840"
instance	{…}
contributorNames	[…]
0	{…}
name	"Graham, Harry C. (Harry Crusen), 1874-1922"
1	{…}
name	"United States. Department of Agriculture. Bureau of Statistics"
identifiers	[…]
0	
identifierTypeId	"c858e4f2-2b6b-4385-842b-60732ee14abb"
value	"agr13000006"
1	
identifierTypeId	"7e591197-f335-4afb-bc6d-a6d76ca3bace"
value	"(OCoLC-M)4965192"
2	
identifierTypeId	"439bfbae-75bc-4f74-9fc7-b2a2d47ce3ef"
value	"ocm04965192"
publication	[…]
0	{…}
dateOfPublication	"1912"
place	"Washington, D.C"
publisher	"U.S. Dept. of Agriculture, Bureau of Statistics"
title	"Coffee : production, trade, and consumption by countries / by Harry C. Graham."
instanceId	"026182d0-7960-5f11-9372-cd31fad68791"
metadata	{…}
createdByUserId	"ad914b1b-06fe-5aef-8446-d60b57395f2f"
createdDate	"2023-05-15T14:27:26.600+00:00"
updatedByUserId	"ad914b1b-06fe-5aef-8446-d60b57395f2f"
updatedDate	"2023-05-15T14:27:26.994+00:00"
pickupServicePoint	{…}
code	"GREEN-LOAN"
description	null
discoveryDisplayName	"Green Library Loan Desk"
name	"Green Loan Desk"
pickupLocation	true
shelvingLagTime	null
pickupServicePointId	"a5dbb3dc-84f8-4eb3-8bfe-c61f74a9e92d"
position	1
requestDate	"2023-05-15T14:27:25.000+00:00"
requester	{…}
barcode	"2555716958"
firstName	"Justin"
lastName	"Coyne"
middleName	"Michael"
patronGroup	{…}
desc	"Staff Member"
group	"staff"
id	"3684a786-6671-4268-8ed0-9db82ebca60b"
patronGroupId	"3684a786-6671-4268-8ed0-9db82ebca60b"
requesterId	"562a5cb0-e998-4ea2-80aa-34ac2b536238"
requestExpirationDate	"2023-05-20T06:59:59.000+00:00"
requestLevel	"Title"
requestType	"Hold"
status	"Closed - Cancelled"

@jcoyne jcoyne moved this from 🏗 In progress to 👀 In review in Searchworks/FOLIO Summer 2022/23 May 19, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Searchworks/FOLIO Summer 2022/23 Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
3 participants