Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unique IDs for contact form fields #199

Merged
merged 1 commit into from
Jul 22, 2019
Merged

Conversation

cbeer
Copy link
Member

@cbeer cbeer commented Jul 22, 2019

Fixes #193; I looked briefly into incorporating HTML validation into our rspec tests, but there's not a clear way to do it, so 🤷‍♂

@mejackreed mejackreed merged commit 52001e8 into master Jul 22, 2019
@mejackreed mejackreed deleted the 193-uniq-html-ids branch July 22, 2019 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validation error - re-using form fields in Feedback & Contact us causes duplicate IDs
2 participants