Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update layout of expanded details content; fixes #192 #198

Merged
merged 1 commit into from
Jul 22, 2019

Conversation

cbeer
Copy link
Member

@cbeer cbeer commented Jul 22, 2019

Fixes #192

Before:
Screen Shot 2019-07-22 at 07 42 12

After:
Screen Shot 2019-07-22 at 07 41 54

@cbeer cbeer force-pushed the 192-expanded-details branch 2 times, most recently from fca79a5 to a8585aa Compare July 22, 2019 16:20
Copy link
Contributor

@mejackreed mejackreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and makes the requested layout changes. However, I wonder if we should just make the column counts equal 12. The offsets are calculating appropriately but it feels like it may not need ancillary additional classes?

col-md-11 offset-md-2 = 13 cols

col-md-2 offset-md-2 + col-8 = 13 cols

Is there a reason @jvine that we need to go to 13 columns here?

@cbeer
Copy link
Member Author

cbeer commented Jul 22, 2019

(I'm going to regret not pulling out helper methods for these, I guess..)

@jvine
Copy link
Contributor

jvine commented Jul 22, 2019

Damn. Yes, my typo. This is correct: <div class="col-11 offset-1 col-md-10 offset-md-2">

But I don't understand this comment:

col-md-2 offset-md-2 + col-8 = 13 cols

<dt class="col-3 offset-1 col-md-2 offset-md-2">
<dd class="col-8">

3 + 1 + 8 = 12, and 2 + 2 + 8 = 12

@cbeer cbeer force-pushed the 192-expanded-details branch from a8585aa to 57f0852 Compare July 22, 2019 17:49
@camillevilla camillevilla merged commit 7f55d1e into master Jul 22, 2019
@camillevilla camillevilla deleted the 192-expanded-details branch July 22, 2019 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layout of expanded details content
4 participants