Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout of expanded details content #192

Closed
3 tasks done
jvine opened this issue Jul 19, 2019 · 0 comments · Fixed by #198
Closed
3 tasks done

Layout of expanded details content #192

jvine opened this issue Jul 19, 2019 · 0 comments · Fixed by #198
Assignees

Comments

@jvine
Copy link
Contributor

jvine commented Jul 19, 2019

For the label/value pairs in the expanded detail panels, the spacing is too loose and affects readability.

  • This seems to work for the <dt> / <dd> pairs:
    <dt class="col-3 offset-1 col-md-2 offset-md-2">
    <dd class="col-8">

  • For "View in SearchWorks" and other standalone links or text:
    <div class="col-11 offset-1 col-md-11 offset-md-2">

  • REMOVE .justify-content-center from the containing rows for both of the above.

Outcomes:

detail layout phone

detail layout sm

detail layout md

detail layout lg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants