ensure all popovers have aria-describedBy #3186
Conversation
| @@ -2,7 +2,7 @@ | |||
| <header>Details *</header> | |||
| <div class="mb-3 row"> | |||
| <div class="col-sm-2"> | |||
| <%= form.label :name, "Collection name *", class: "col-form-label" %> | |||
| <%= form.label :name, "Collection name *", class: "col-form-label", "aria-describedby": "popover-collection.name" %> | |||
There was a problem hiding this comment.
Should the aria-describedby be on the label or on the input?
There was a problem hiding this comment.
good question - i was assuming the description was of the input, but i could be convinced it was the label too... we can verify with an expert
There was a problem hiding this comment.
I think this is correct ... it is and should be the label, this is what is the tooltip is right next to and is what it is tied to
There was a problem hiding this comment.
Right, but the label is tied to the input. So if the label is describing the input then isn't the tooltip also describing the input?
peetucket
force-pushed
the
3171-welcome-accessibility-2
branch
from
9e0f2e8
to
bb4a1c2
Compare
I added a comment to the top of |
peetucket
force-pushed
the
3171-welcome-accessibility-2
branch
from
267bec3
to
8aa8e33
Compare
peetucket
force-pushed
the
3171-welcome-accessibility-2
branch
from
8aa8e33
to
7ee7f02
Compare
|
Note, after looking at https://inclusive-components.design/tooltips-toggletips/#inclusivetoggletips will leave this as is with aria-describedby tags, but have now moved the element they are attached to in some cases. Where it made sense, I moved to the form input being described. In some cases the tip is describing a section, so left on the label or legend in those cases. |
peetucket
force-pushed
the
3171-welcome-accessibility-2
branch
from
09538eb
to
130135a
Compare
Why was this change made? 🤔
Fixes one accessibility item in #3171
Note, after looking at https://inclusive-components.design/tooltips-toggletips/#inclusivetoggletips will leave this as aria-describedby tags, but have now moved the element they are attached to, in some cases to the form input. In some cases, the tip is describing a section, so left on the label or legend in those cases.
How was this change tested? 🤨
Localhost