-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some accessibility fixes for welcome/home page #3179
Conversation
f0594c2
to
2453f4f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we sit on this until we can convert I hope it reduces them!
to We ran a set of tools to verify these issues, and now they're gone, and no new ones are introduced
❓
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you split this PR into the two commits, I'll merge a PR with the first commit (with one tweak I noted in a comment).
2d89f10
to
0625f2e
Compare
0625f2e
to
5eb7931
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving this. Agree that it would be good to have a tool to show us this fixed something and didn't break anything else.
Why was this change made? 🤔
Addresses some of the accessibility issues identified in #3171
How was this change tested? 🤨
Localhost and CI
Does your change introduce accessibility violations? 🩺
I hope it reduces them!