Rakes tasks for working with data import profiles #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgreben
requested changes
Feb 8, 2024
There was a problem hiding this comment.
Do we still need this method? If not, it can be removed:
folio-tasks/tasks/helpers/data_import.rb
Line 217 in 6ec600c
|
On second thought, I might want to use that method instead. Let me re-work this PR a bit. |
We do not want to load the system default data import job_profiles since they are loaded when we enable modules with okapi and loadReference=true.
shelleydoljack
force-pushed
the
t288-data-import
branch
from
c3225e5 to
48ca18c
Compare
I ended up removing it. This is ready for review now. |
jgreben
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #288