Moves method to remove system profiles to data import helper.

sul-dlss · Feb 13, 2024 · 48ca18c · 48ca18c
1 parent 9d519cd
commit 48ca18c
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 33 deletions.
diff --git a/tasks/helpers/data_import.rb b/tasks/helpers/data_import.rb
@@ -128,25 +128,29 @@ def profile_associations_put(payload, master, detail)
 
   def pull_action_profiles
     hash = @@folio_request.get('/data-import-profiles/actionProfiles?withRelations=true&limit=999')
-    trim_default_data(hash, 'actionProfiles')
+    trim_hash(hash, 'actionProfiles')
+    remove_system_profiles(hash, 'actionProfiles')
     hash.to_json
   end
 
   def pull_job_profiles
     hash = @@folio_request.get('/data-import-profiles/jobProfiles?limit=999')
-    trim_default_data(hash, 'jobProfiles')
+    trim_hash(hash, 'jobProfiles')
+    remove_system_profiles(hash, 'jobProfiles')
     hash.to_json
   end
 
   def pull_mapping_profiles
     hash = @@folio_request.get('/data-import-profiles/mappingProfiles?withRelations=true&limit=999')
-    trim_default_data(hash, 'mappingProfiles')
+    trim_hash(hash, 'mappingProfiles')
+    remove_system_profiles(hash, 'mappingProfiles')
     hash.to_json
   end
 
   def pull_match_profiles
     hash = @@folio_request.get('/data-import-profiles/matchProfiles?withRelations=true&limit=999')
-    trim_default_data(hash, 'matchProfiles')
+    trim_hash(hash, 'matchProfiles')
+    remove_system_profiles(hash, 'matchProfiles')
     hash.to_json
   end
 
@@ -214,16 +218,16 @@ def profile_associations_load(payload, master, detail)
     end
   end
 
-  def remove_values(hash, key_name)
-    hash.each do |k, v|
-      if k == key_name
-        hash.delete(k)
-      elsif v.is_a?(Hash)
-        remove_values(v, key_name)
-      elsif v.is_a?(Array)
-        v.flatten.each { |x| remove_values(x, key_name) if x.is_a?(Hash) }
-      end
+  def remove_system_profiles(hash, name)
+    new_hash = []
+    hash[name].each do |obj|
+      next if obj['userInfo']['userName'] == 'System'
+
+      obj.delete('parentProfiles')
+      obj.delete('childProfiles')
+      obj.delete('userInfo')
+      new_hash.append(obj)
     end
-    hash
+    hash[name] = new_hash
   end
 end
diff --git a/tasks/helpers/folio_request.rb b/tasks/helpers/folio_request.rb
@@ -19,23 +19,4 @@ def trim_hash(hash, name)
     hash.delete('resultInfo')
     hash
   end
-
-  def trim_default_data(hash, name)
-    new_hash = []
-    hash[name].each do |obj|
-      next if obj['userInfo']['userName'] == 'System'
-
-      obj.delete('childOf')
-      obj.delete('grantedTo')
-      obj.delete('dummy')
-      obj.delete('deprecated')
-      obj.delete('authentication')
-      obj.delete('parentProfiles')
-      obj.delete('childProfiles')
-      new_hash.append(obj)
-    end
-    hash.delete('totalRecords')
-    hash.delete('resultInfo')
-    hash[name] = new_hash
-  end
 end