Update the output filename to include data_path for versioning and... #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roved user experience
aaron-collier
force-pushed
the
rename-output-by-data-dir
branch
from
a92143d to
705eb35
Compare
jacobthill
approved these changes
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... improved user experience
Why was this change made?
In order to provide a better curatorial user experience, we need to be able to clear out and find transformed data (and associate it with a collection). This is complicated by the uuid based file naming as it limits versioning abilities in S3 and leads to excessive storage of older (unusable) transformations.
This is part of sul-dlss/dlme#1153
New filename pattern:
https://.../dlme-metadata-dev/output-stanford.ndjsonHow was this change tested?
N/A
Which documentation and/or configurations were updated?