add translations #787
Merged
add translations #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aaron-collier I tried to rebase this but I think I added some changes that weren't supposed to be added. I don't want to make it worse. Can you fix this please? |
aaron-collier
force-pushed
the
translations
branch
from
6f36593 to
c2dc6b1
Compare
aaron-collier
force-pushed
the
translations
branch
from
4c6ffbe to
859a230
Compare
jmartin-sul
requested changes
Aug 17, 2021
There was a problem hiding this comment.
a couple questions about changes to the translation maps, not sure if typos in translation maps or if typos upstream being accounted for by translation maps. and one question about a removed TODO that seemed like maybe it should've stayed.
the "request changes" is more about the TODO, since i wasn't sure whether i'd noticed an actual problem with the translations.
jmartin-sul
approved these changes
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why was this change made?
How was this change tested?
Which documentation and/or configurations were updated?