don't return null when no preview #771
Conversation
| 'wr_edm_rights' => [literal('CC BY-ND: https://creativecommons.org/licenses/by-nd/4.0/')], | ||
| 'wr_id' => [extract_poha('/*/dc:thumbnail')] | ||
| ) | ||
| end |
There was a problem hiding this comment.
mostly asking for my own traject-related edification: is it correct to say that the old version would apply the transform_values call to every record, pushing the result onto accumulator, and that the new version examines every record, applying the transform_values call to the record and pushing the result onto accumulator, but skipping the record entirely if a thumbnail xpath` isn't present?
wondering because this is the first time i've seen the each_record call in the middle of a bunch of to_field configuration calls.
There was a problem hiding this comment.
Yes, this is correct. It will leave agg_preview out of the IR if a thumbnail xpath is not found.
|
on second thought, refraining from merging till @aaron-collier can take a look. i got hesitant since i don't totally grok the |
Why was this change made?
at least one AUB record did not have a thumbnail and was failing type validation
How was this change tested?
local transform
Which documentation and/or configurations were updated?
n/a