Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to Python 3 #24

Closed
wants to merge 1 commit into from
Closed

Port to Python 3 #24

wants to merge 1 commit into from

Conversation

rhl-bthr
Copy link

@rhl-bthr rhl-bthr commented Apr 7, 2018

No description provided.

@quozl
Copy link
Collaborator

quozl commented Apr 8, 2018

Reviewed to 4fc05b3.

@rhl-bthr
Copy link
Author

Although this PR is complete and (probably) won't need updating, I have left it as in-porgress since the six port of Sugar-Toolkit-GTK+ 3 is not yet complete and gets tested as I port activities.

@quozl @walterbender Is this approach fine or can there be a better alternate to this

@quozl
Copy link
Collaborator

quozl commented Apr 12, 2018

Without the toolkit ported, Write would stop working if we merged this. We'll need to go through a toolkit release cycle first. sugarlabs/sugar-toolkit-gtk3#382 updated "release new version".

@rhl-bthr
Copy link
Author

Sorry, rephrasing my question,
Should I keep opening such In-progress PRs (not to be merged) of porting activities to Python 3, since it helps in testing my six port of Sugar-Toolkit-GTK3

@quozl
Copy link
Collaborator

quozl commented Apr 12, 2018

Create a branch python3 in the activity, and make the pull request against that branch?

@rhl-bthr
Copy link
Author

Sure, will do the same in future, Thank you

@rhl-bthr rhl-bthr changed the title [In progress] Port to Python 3 Port to Python 3 Jul 24, 2018
Tested-by: Rahul Bothra <[email protected]> # Ubuntu 16.04
@quozl
Copy link
Collaborator

quozl commented Aug 9, 2018

Rebased against new master and pushed with --force.

@rhl-bthr
Copy link
Author

This and other PRs for porting activities to Python 3 are open.
I've left the ones running successfully with sugar-toolkit-gtk3/python3-port, as open.

@quozl
Copy link
Collaborator

quozl commented Jan 18, 2019

Thanks.

@quozl
Copy link
Collaborator

quozl commented Feb 21, 2019

Rebased against new master and pushed with --force to the python3 branch because the repository associated with this pull request has vanished. I've no idea how to push to the pull request once that happens.

@rhl-bthr rhl-bthr closed this Feb 22, 2019
@rhl-bthr rhl-bthr mentioned this pull request Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants