Port to Six #383

rhl-bthr · 2018-03-01T12:10:23Z

Changes made/being made in this PR: #382

walterbender · 2018-03-01T17:36:28Z

It will be hard to test the individual files stand-alone and I don't think our build system tests will be of much use. I will think about it.

Re telepathy, we'll have to do extensive testing of the Python 3 port as well. But maybe we can also ping Collabora to see if they have a Python3 equivalent (more likely to be maintained) toolkit we can begin migrating towards.

quozl · 2018-03-01T20:09:55Z

I don't know how to fix the reference to jarabe.model. Can the needed functionality be moved into the toolkit?

Who is pinging Collabora?

I don't know which extensions will be affected.

quozl · 2018-03-02T06:01:43Z

Reviewed up to 743742d.

quozl · 2018-03-03T00:10:42Z

Reviewed to 53f6a20.

quozl · 2018-03-05T08:55:01Z

Reviewed to 89dc9ed.

quozl · 2018-03-11T23:44:51Z

Reviewed to 9699941.

I do not think there will be a port of all activities. It would be nice, but I'm a realist. 😁

Perhaps a better alternative is to use in activity.info;

exec = sugar-activity3 activity.ClassName

Also consider;

documentation for exec in src/sugar3/bundle/__init__.py
tests/data/sample.activity/activity/activity.info

Now that you have a ported activity, please also contribute to sugarlabs/sugar-docs#145.

quozl · 2018-03-26T03:05:11Z

Reviewed to a50e843.

quozl · 2018-04-01T23:19:12Z

Reviewed to 19b551f. These last two deserve to jump the queue and land now, but 19b551f has several merge conflicts. Your ccbf8a4 has been cherry-picked and pushed as 8f047b5.

quozl · 2018-04-17T09:24:21Z

Reviewed to f833bff.

quozl · 2018-05-15T08:56:45Z

Reviewed to 1730e21.

quozl · 2018-06-28T02:17:31Z

doc/index.rst

@@ -2,7 +2,7 @@ Sugar Toolkit GTK3
 ==================

 Sugar Toolkit GTK3, or `sugar3`, is a toolkit for writing Sugar
-activities in Python:
+activities in Python 3:


Also in Python 2, so I suggest removing this change.

quozl · 2018-06-28T02:20:13Z

bin/sugar-activity

-        instance.run_main_loop()
-
-main()
+activityinstance.main()


Missing new line mark at end of file.

quozl · 2018-06-28T02:20:23Z

bin/sugar-activity3

+
+from sugar3.activity import activityinstance
+
+activityinstance.main()


Missing new line mark at end of file.

quozl · 2018-06-28T02:22:14Z

src/sugar3/bundle/__init__.py

-* `exec` - how to execute the activity, e.g. `sugar-activity module.Class`,
+* `exec` - how to execute the activity, e.g.
+  `sugar-activity3 module.Class` (For activities written in Python 3),
+  `sugar-activity module.Class` (For activities written in Python 2)


Both lines, should be "activities written for" rather than in. An activity could potentially instantiate both Python 2 and Python 3 interpreters in separate processes.

quozl · 2018-06-28T02:27:12Z

@Pro-Panda, do you have Debian styled packages for this branch yet?

anmol27katyani · 2018-06-28T06:44:14Z

configure.ac

@@ -15,7 +15,7 @@ GNOME_COMPILE_WARNINGS(maximum)

 AC_PATH_PROG([GLIB_GENMARSHAL], [glib-genmarshal])

-PYTHON=python2
+PYTHON=python3


It specifically installs for python3
We need toolkit to be 2&3 compatible

yes, I know. I don't yet have a fix for installing for both Python 2 and Python 3.

I am leaving this change as is for now, since LEM doesn't hold here.
Reference: https://en.wikipedia.org/wiki/Law_of_excluded_middle

@pro-panda so the sugar toolkit is not yet completely 2 & 3 compatible?

It is compatible. You can override PYTHON when you call configure.ac, right?

Yes @quozl , as per my undersatnding in that case it will install either python 2 or python 3 and it totally depends upon user how they want to install the toolkit.

rhl-bthr · 2018-06-28T06:56:38Z

@quozl, no.
The package should ideally install for both Python 2 and Python 3. I am still working on how to do that

quozl · 2018-06-28T07:13:18Z

We need the source package (the .tar.xz) to be capable of being installed for both python2 and python3, but not at the same time. The duty to do both is given to the user of the source package; such as the Fedora or Debian packager, or an end-user doing a native install by hand.

So I'll consider the changes for sugar-toolkit-gtk3 to be complete in this respect once PYTHON can be set to either, at the shell prompt. At the moment, we're overriding PYTHON rather than using a default.

rhl-bthr · 2018-07-08T12:41:30Z

@quozl
examples/ticket2855, ticket2999 and ticket3000 don't seem to be linked to https://bugs.sugarlabs.org/ticket/2855, and others respectively. Is there a different ticket they are referring to ?

quozl · 2018-07-12T07:29:47Z

Is there a different ticket they are referring to ?

Yes, the OLPC bug tracker; e.g. http://dev.laptop.org/ticket/2855

quozl · 2018-07-12T07:32:51Z

Reviewed 1f34c2d.

I don't understand why 57168c7 is needed; why can't a Sugar Web activity, which is written in JavaScript, use sugar-activity-web ported to Python 3?

quozl · 2018-07-31T08:06:45Z

Rebased on master. @Pro-Panda, please save your local branch and check against your GitHub branch.

quozl · 2018-07-31T08:46:41Z

Reviewed to cc3050f.

quozl · 2018-08-03T02:50:46Z

Reviewed to bd386f7.

quozl · 2018-08-07T23:40:58Z

Reviewed to 0ec673f.

quozl · 2018-09-24T03:11:35Z

@pro-panda, I'm unable to import sugar3 in Python 3. Have you any idea why?

Here's what I've done;

installed a Debian Stretch VM, using Sugar Live Build,
checked out this branch, autogen.sh, configure, make, make install,
tried import sugar3 within Python, which gives ImportError: No module named 'sugar3',

Here's what I've found since;

the make install has copied files to /usr/lib/python3.5/site-packages/sugar3,
installing python3-serial package has placed files in /usr/lib/python3/dist-packages,
renaming site-packages to dist-packages fixes the import fail,
moving the sugar3 directory from the first to the second directory fixes the import fail.

So it would seem that our make install uses the wrong place. Looks like it gets this wrong place from /usr/share/aclocal-1.15/python.m4. It seems to be a Debian feature;

rhl-bthr · 2018-09-29T12:30:08Z

Thanks for testing. I agree. Reproduced on Ubuntu 16.04.

ghost · 2018-09-29T14:02:40Z

On Sun, Sep 23, 2018 at 08:11:36PM -0700, James Cameron wrote: @pro-panda, I'm unable to import sugar3 in Python 3. Have you any idea why? Here's what I've done; • installed a Debian Stretch VM, using Sugar Live Build, • checked out this branch, autogen.sh, configure, make, make install, • tried import sugar3 within Python, which gives ImportError: No module named 'sugar3', Here's what I've found since; • the make install has copied files to /usr/lib/python3.5/site-packages/ sugar3, • installing python3-serial package has placed files in /usr/lib/python3/ dist-packages, • renaming site-packages to dist-packages fixes the import fail, • moving the sugar3 directory from the first to the second directory fixes the import fail. So it would seem that our make install uses the wrong place.

This is just a start as to how to understand how to reconcile the two locations: https://stackoverflow.com/questions/9387928/whats-the-difference-between-dist-packages-and-site-packages#9388115 but from that it looks like each method of installing was doing what it was supposed to do, under Debian policy. The question is how to reconcile the different uses of the two? Rather than trying to make one or the other work, perhaps configuring path variables to check both types of locations is the way forward?

quozl · 2018-10-27T03:28:44Z

I'm guessing from the policy Debian just doesn't support user-installed system-wide Python packages without the user also changing the path.

Best ways forward seem to depend on target;

for Sugar Live Build, which does a git clone then make install, we'll have to move the sugar3 directory as a workaround,
for Debian or Ubuntu packaging building, no action needed.

I've not evaluated Fedora.

rhl-bthr · 2018-10-27T07:18:27Z

for Sugar Live Build, which does a git clone then make install, we'll have to move the sugar3 directory as a workaround,

I agree. I couldn't find an alternate as well

* Embedded the single used instance in itself

* avoid name clashing with the name of the module imported

Activities could not be started, shell.log contained Traceback (most recent call last): File "/usr/lib/python2.7/dist-packages/dbus/connection.py", line 604, in msg_reply_handler reply_handler(*message.get_args_list(**get_args_opts)) File "/usr/lib/python2.7/sugar3/activity/activityfactory.py", line 251, in _activate_reply_handler self._create_activity() File "/usr/lib/python2.7/sugar3/activity/activityfactory.py", line 222, in _create_activity (log_path, log_file) = open_log_file(self._bundle) File "/usr/lib/python2.7/sugar3/activity/activityfactory.py", line 140, in open_log_file f = open(fd, 'w') TypeError: coercing to Unicode: need string or buffer, int found

quozl · 2019-03-13T01:43:21Z

@pro-panda, tested on Ubuntu 18.04 with Python 2 and fixed a problem with starting activities, see d3ac3e5. Is the change rational? I undid your change. See os.fdopen.

quozl · 2019-03-13T04:43:17Z

Merged as aa8a5e7, thanks!

Aniket21mathur · 2019-03-22T05:42:24Z

Any further work required to be done on this pr? It is still a part of Project Task Checklist for port to python3 project. Thanks!

quozl · 2019-03-22T08:21:42Z

See #382 for the work remaining to be done.

Aniket21mathur · 2019-05-19T04:53:21Z

I'm guessing from the policy Debian just doesn't support user-installed system-wide Python packages without the user also changing the path.

Best ways forward seem to depend on target;

for Sugar Live Build, which does a git clone then make install, we'll have to move the sugar3 directory as a workaround,

for Debian or Ubuntu packaging building, no action needed.

I've not evaluated Fedora.

I think there is a need to include this in the Native build documentation. Suggestions?
I made a pull request sugarlabs/sugar#831 though!

quozl · 2019-05-20T01:07:34Z

Sure. It's a mess. Debian and Fedora both seem to have problems dealing with installing Python programs using autotools into /usr/local. It is a path not often tread, so it is unlikely to gain attention.

Sub task make local Fedora and Debian packages for testing by others in each of our Port to Python 3 issues should help to ensure our release, when made, will build and run on Fedora and Debian.

rhl-bthr changed the title ~~[In Progress] Port src/sugar3/graphics to Python3~~ [In Progress] Port src/sugar3/graphics to six Mar 1, 2018

This comment has been minimized.

Sign in to view

rhl-bthr changed the title ~~[In Progress] Port src/sugar3/graphics to six~~ [In Progress] Port Python code to six Mar 3, 2018

This comment has been minimized.

Sign in to view

quozl mentioned this pull request Mar 9, 2018

Port to Six { Ongoing } #385

Closed

10 tasks

This comment has been minimized.

Sign in to view

rhl-bthr mentioned this pull request Apr 12, 2018

Port to Python 3 sugarlabs/write-activity#24

Closed

rhl-bthr mentioned this pull request Jun 1, 2018

Port to Python 3 sugarlabs/sugar-datastore#8

Closed

quozl requested changes Jun 28, 2018

View reviewed changes

anmol27katyani reviewed Jun 28, 2018

View reviewed changes

rhl-bthr changed the title ~~[In Progress] Port Python code to six~~ Port to six Jul 24, 2018

quozl approved these changes Jul 31, 2018

View reviewed changes

quozl changed the title ~~Port to six~~ Port to Six Aug 13, 2018

rhl-bthr mentioned this pull request Jan 21, 2019

Port to Python 3 sugarlabs/sugar#805

Closed

Pro-Panda and others added 10 commits March 13, 2019 12:31

Port from Python 2 to six

567f916

Set PEP8

ba7d27c

Add warning for Python 2 activities

9a62f48

Use pixel_size instead of icon_size

f08b981

Remove unused popwindow instance

b834dfc

* Embedded the single used instance in itself

Rename unittest to _unittest

da4178c

* avoid name clashing with the name of the module imported

remove redundant import

1e799d9

Add activityinstance.py to makefile

1ae67bd

Fix import error

4f1e5a6

quozl closed this Mar 13, 2019


		from sugar3.activity import activityinstance

		activityinstance.main()

Port to Six #383

Port to Six #383

Conversation

rhl-bthr commented Mar 1, 2018 • edited Loading

This comment has been minimized.

This comment has been minimized.

walterbender commented Mar 1, 2018

This comment has been minimized.

quozl commented Mar 1, 2018

quozl commented Mar 2, 2018

quozl commented Mar 3, 2018

This comment has been minimized.

quozl commented Mar 5, 2018

This comment has been minimized.

quozl commented Mar 11, 2018

quozl commented Mar 26, 2018

quozl commented Apr 1, 2018

quozl commented Apr 17, 2018

quozl commented May 15, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

quozl commented Jun 28, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rhl-bthr commented Jun 28, 2018

quozl commented Jun 28, 2018

rhl-bthr commented Jul 8, 2018

quozl commented Jul 12, 2018

quozl commented Jul 12, 2018

quozl commented Jul 31, 2018 • edited Loading

quozl commented Jul 31, 2018

quozl commented Aug 3, 2018

quozl commented Aug 7, 2018

quozl commented Sep 24, 2018 • edited Loading

rhl-bthr commented Sep 29, 2018

ghost commented Sep 29, 2018 via email

quozl commented Oct 27, 2018

rhl-bthr commented Oct 27, 2018

quozl commented Mar 13, 2019 • edited Loading

quozl commented Mar 13, 2019

Aniket21mathur commented Mar 22, 2019

quozl commented Mar 22, 2019

Aniket21mathur commented May 19, 2019 • edited Loading

quozl commented May 20, 2019

rhl-bthr commented Mar 1, 2018 •

edited

Loading

quozl commented Jul 31, 2018 •

edited

Loading

quozl commented Sep 24, 2018 •

edited

Loading

quozl commented Mar 13, 2019 •

edited

Loading

Aniket21mathur commented May 19, 2019 •

edited

Loading