BugFix: Scalar step behaving incorrectly inside invert #2789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meganindya
force-pushed
the
inversion-bug
branch
from
fd95fd0 to
d6d2c6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2318
For input
Output is
Please mind the notes, visual appearance might differ depending upon the editor used.For Input
Output is
Please mind the notes, visual appearance might differ depending upon the editor used.Some more tests
Odd inversion of C4, Step -1(B4) about D4 -> F F#
Scalar Inversion of B4, Step -1(A4) about G4 -> E F
So all three inversions, even, odd and scalar seem to work fine now with scalar block inside invert.
Please share feedback and reviews. Thanks