Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invert doesn't work with scalar step block #2318

Closed
walterbender opened this issue Jun 6, 2020 · 4 comments · Fixed by #2789
Closed

invert doesn't work with scalar step block #2318

walterbender opened this issue Jun 6, 2020 · 4 comments · Fixed by #2789

Comments

@walterbender
Copy link
Member

If you create a scale with the scalar step block, you'd expect the scale to invert when you play it back. Instead it seems to apply the step to the inverted note, creating a toggle back and forth.

Screenshot from 2020-06-06 08-47-14

Inverting this code:

Screenshot from 2020-06-06 08-49-10

I'd expect:

reflect

but we get:

Screenshot from 2020-06-06 08-48-16

@jatinverma12
Copy link

@walterbender I am trying to understand the project but I think I am finding needle in the bush. Could you please help me getting a good start. I want to make open source contribution.

@walterbender
Copy link
Member Author

This one is pretty tricky. The scalar step block steps based on the previous note. But if that note was inverted then it will step from the inverted note instead. I think we need to figure out if the scalar step is inside an invert and do the following:

  1. uninvert the previous note
  2. step
  3. invert the result.

This is prob. not a good first issue.

@joykirat18
Copy link
Member

When I ran the test I got this result
Screenshot 2021-01-25 at 1 26 34 AM
Screenshot 2021-01-25 at 1 26 44 AM

But this is different from your result. Can you please help me understand what the issue is? I would like to solve this issue.

@walterbender
Copy link
Member Author

Invert should invert the scale. What is happening in your test is that the first note is inverted but the rest are stepped up from the inverted note instead of stepped down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants