Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup automated releases #141

Closed
jacques-n opened this issue Feb 20, 2022 · 5 comments · Fixed by #156
Closed

Setup automated releases #141

jacques-n opened this issue Feb 20, 2022 · 5 comments · Fixed by #156
Assignees

Comments

@jacques-n
Copy link
Contributor

@cpcloud and I have been discussing introducing automated releases/release notes and starting to version things. We should get this going since other projects would be much better off depending on a released set of substrait proto definitions, etc as opposed to using a git hash.

@cpcloud
Copy link
Contributor

cpcloud commented Feb 20, 2022

Yep, I can look into this.

@winningsix
Copy link

Any more details for this? One quick question around this, for a Substrait dependent project, will Substrait be linked as a Git submodule or include protobuf there?

@jacques-n
Copy link
Contributor Author

I think this will depend on the language. For things like Javascript, Java and, python I think we should publish compiled files. For c and c++ I think we should probably publish a tgz with the proto files. What do others think?

@FelixYBW
Copy link

Do we have plan to create and release the helper tools for each language as well? Like substrait_plan_builder etc.? The builder function will be useful to create and test substriat plans consumers. If so for c/c++ we may need to publish a library as well in future.

@jacques-n
Copy link
Contributor Author

Do we have plan to create and release the helper tools for each language as well? Like substrait_plan_builder etc.?

Yes, I think we should do that. I'm definitely trying to provide that as part of the java patch I'm working on.

@cpcloud cpcloud linked a pull request Apr 28, 2022 that will close this issue
rkondakov pushed a commit to rkondakov/substrait that referenced this issue Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants