Add Substrait-to-Velox conversion #1048

rui-mo · 2022-02-15T11:56:32Z

This pr is targeted to add the base layout for Substrait-to-Velox conversion. With this change, the base layout of Substrait-to-Velox conversion would be decided. Some of Substrait plan representations can be converted into Velox plan for computing. More conversions support will be added in following pull requests.

Based on Substrait Commit.

The used function names are based on: Substrait PR.

facebook-github-bot · 2022-02-15T11:56:36Z

Hi @rui-mo!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

pedroerp · 2022-02-17T02:18:25Z

This is great, thanks for contributing this back to Velox! Before I start looking at the code, I wonder if you already had thoughts on how we would add the dependent Substrait headers to ensure these files build on circleCI and that are easily usable by Velox developers.

I happy to help brainstorming if you haven't!

rui-mo · 2022-02-18T09:55:12Z

This is great, thanks for contributing this back to Velox! Before I start looking at the code, I wonder if you already had thoughts on how we would add the dependent Substrait headers to ensure these files build on circleCI and that are easily usable by Velox developers.

I happy to help brainstorming if you haven't!

Thanks for you advice. The Substrait hearders can be automatically generated with some commands in CMakeLists. We will soon try to port this part from our implementations to Velox, thanks!

Update:
There are two ways we are thinking of to make the comiplation work:

One is to git clone Substrait proto files each time in compilation, and then automatically compile these Substrait headers during Velox's compilation.
The other is to put these Substrait protos into Velox, and then automatically compile the headers during Velox's compilation.

But the latter way may be better to depend on a Substrait release. As Substrait committer mentioned in the PR, they are considering making a release. Which one is better on your opinion? What suggestion do you have for the integration for Substrait into Velox?

jacques-n · 2022-02-20T00:02:39Z

One of the things we need to do in Substrait is to start releasing releases so people don't have to depend on git hash versions. @cpcloud, any chance you could take a look at substrait-io/substrait#141 to help with this?

rui-mo · 2022-02-22T02:04:56Z

Substrait headers can be automatically generated, and the code compilation works now. A unit test was added, in which input would be a dumped Substrait plan, and output would be Velox computing result. Working on solving the multiple reference issues for the compilation of unit test. For now, Substrait proto files were put into Velox. If you have other opinion, please let me know, thanks.

winningsix · 2022-02-23T03:38:26Z

@pedroerp @jacques-n Quick question: Will this PR depend on Substrait release or not? Your thoughts here. I will suggest to live with what Substrait already has. And rebase on release in a follow-up PR.

jacques-n · 2022-02-23T03:53:31Z

My recommendation would be that if the team wants to merge this before a release, we at least ensure it is from a commit in Substrait main branch. I don't think that it should super long to get to a first release. Thoughts @cpcloud?

winningsix · 2022-02-23T04:00:18Z

@jacques-n which commmit should be based on?

jacques-n · 2022-02-23T04:15:25Z

Something in Substrait main branch. Preferably latest available commit.

rui-mo · 2022-02-23T05:49:35Z

OK, will rebase this PR to the latest available Substrait commit before getting the release.

facebook-github-bot · 2022-02-24T07:24:18Z

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

rui-mo · 2022-02-25T01:46:59Z

Updated Substrait to the latest available commit and added a unit test to read Json file and test Velox's computing. All Github checks were passed. This PR is ready for review now, thanks.

pedroerp

Thanks for looking into this! A few comments inline:

pedroerp · 2022-02-25T16:40:30Z

CMakeLists.txt

@@ -41,6 +41,7 @@ option(VELOX_ENABLE_PARSE "Build parser used for unit tests." ON)
 option(VELOX_ENABLE_EXAMPLES
       "Build examples. This will enable VELOX_ENABLE_EXPRESSION automatically."
       ON)
+option(VELOX_ENABLE_SUBSTRAIT "Buid Substrait-to-Velox converter." ON)


Should we leave this off by default? Looks to me that using Substrait (at least for now) will the exception rather than the norm.

Turned OFF in the latest commit.

pedroerp · 2022-02-25T16:41:34Z

velox/CMakeLists.txt

+
+# substrait converter
+if(${VELOX_ENABLE_SUBSTRAIT})
+  add_subdirectory(substrait_converter)


Can we rename this directory to just "substrait", to follow the conversion pattern we use for "arrow" and ""dubckdb"?

Renamed to "substrait" in the latest commit.

pedroerp · 2022-02-25T16:48:10Z

velox/substrait_converter/SubstraitToVeloxExpr.h

+class SubstraitVeloxExprConverter {
+ public:
+  SubstraitVeloxExprConverter(
+      const std::shared_ptr<SubstraitParser>& sub_parser,


please use lower camel base for argument names - check out our coding style here:

https://github.com/facebookincubator/velox/blob/main/CODING_STYLE.md

Fixed them in the latest commit.

pedroerp · 2022-02-25T16:48:58Z

velox/substrait_converter/SubstraitToVeloxExpr.h

+  std::shared_ptr<const core::FieldAccessTypedExpr> toVeloxExpr(
+      const substrait::Expression::FieldReference& sfield,
+      const int32_t& input_plan_node_id);
+  std::shared_ptr<const core::ITypedExpr> toVeloxExpr(


nit: blank line in between methods.

pedroerp · 2022-02-25T16:49:44Z

velox/substrait_converter/SubstraitToVeloxExpr.h

+// This class is used to convert Substrait representations to Velox expressions.
+class SubstraitVeloxExprConverter {
+ public:
+  SubstraitVeloxExprConverter(


Could we have a comment here explaining what functions_map is and how it's used in this class?

Comments were added in the latest commit.

pedroerp · 2022-02-25T17:00:56Z

velox/substrait_converter/SubstraitToVeloxExpr.cpp

+SubstraitVeloxExprConverter::toVeloxExpr(
+    const substrait::Expression::ScalarFunction& sfunc,
+    const int32_t& input_plan_node_id) {
+  std::vector<std::shared_ptr<const core::ITypedExpr>> params;


nit: reserve the vector first.

How many should be reserved for the vector? Because the number of items seems to be unknown.

pedroerp · 2022-02-25T17:01:11Z

velox/substrait_converter/SubstraitToVeloxExpr.cpp

+    const substrait::Expression::ScalarFunction& sfunc,
+    const int32_t& input_plan_node_id) {
+  std::vector<std::shared_ptr<const core::ITypedExpr>> params;
+  for (auto& sarg : sfunc.args()) {


const auto&

Fixed the cases like this.

pedroerp · 2022-02-25T17:01:55Z

velox/substrait_converter/SubstraitToVeloxExpr.cpp

+    auto expr = toVeloxExpr(sarg, input_plan_node_id);
+    params.push_back(expr);
+  }
+  auto function_id = sfunc.function_reference();


camel case throughout

pedroerp · 2022-02-25T17:03:09Z

velox/substrait_converter/SubstraitToVeloxExpr.cpp

+SubstraitVeloxExprConverter::toVeloxExpr(
+    const substrait::Expression::Literal& slit) {
+  switch (slit.literal_type_case()) {
+    case substrait::Expression_Literal::LiteralTypeCase::kFp64: {


to make it shorter:

case substrait::Expression_Literal::LiteralTypeCase::kFp64: return std::make_shared<core::ConstantTypedExpr>(slit.fp64()); case ...

pedroerp · 2022-02-25T17:04:24Z

velox/substrait_converter/SubstraitToVeloxExpr.cpp

+      return std::make_shared<core::ConstantTypedExpr>(val);
+      break;
+    }
+    case substrait::Expression_Literal::LiteralTypeCase::kBoolean: {


default: VELOX_NYI("Substrait conversion not supported for type '{}'", toString(slit));

pedroerp · 2022-03-03T01:05:12Z

velox/substrait/SubstraitToVeloxExpr.h

+
+  /// The Substrait parser used to convert Substrait representations into
+  /// recognizable representations.
+  std::shared_ptr<SubstraitParser> subParser_;


nit: blank line before the comment block

Fixed the cases like this.

pedroerp · 2022-03-03T01:05:25Z

velox/substrait/SubstraitToVeloxExpr.h

+  std::shared_ptr<SubstraitParser> subParser_;
+  /// The map storing the relations between the function id and the function
+  /// name.
+  std::unordered_map<uint64_t, std::string> functionMap_;


pedroerp · 2022-03-03T01:07:30Z

velox/substrait/SubstraitToVeloxExpr.cpp

+
+void SubstraitVeloxExprConverter::getFlatConditions(
+    const ::substrait::Expression& sFilter,
+    std::vector<::substrait::Expression_ScalarFunction>* scalarFunctions) {


pointers are usually to specify this parameter is optional, but it doesn't seem to be the case. Could we take it as a non-const ref instead?

Fixed the cases like this.

pedroerp · 2022-03-03T01:09:29Z

velox/substrait/SubstraitToVeloxExpr.cpp

+      break;
+    }
+    default:
+      VELOX_NYI("GetFlatConditions not supported for type '{}'", typeCase);


Is there a toString() sort of method for typeCase? I'm assuming this is a enum, so we would end up printing the integer value, which is not very helpful to users.

Yes, the typeCase is just integer value. But after searching out, did not find an elegant way to map this integer value to the key word in enum. I found two options not quite simple:

Construct a map to store the mapping relations

Use a tool to map the integer back to key word: https://github.com/Neargye/magic_enum

pedroerp · 2022-03-03T01:12:49Z

velox/substrait/SubstraitToVeloxExpr.cpp

+SubstraitVeloxExprConverter::toVeloxExpr(
+    const ::substrait::Expression::ScalarFunction& sFunc,
+    const int32_t& inputPlanNodeId) {
+  std::vector<std::shared_ptr<const core::ITypedExpr>> params;


reserve it first?

params.reserve(sFunc.args().size());

Fixed the cases like this.

pedroerp · 2022-03-03T01:15:45Z

velox/substrait/SubstraitToVeloxExpr.cpp

+  auto typeCase = sExpr.rex_type_case();
+  switch (typeCase) {
+    case ::substrait::Expression::RexTypeCase::kLiteral: {
+      veloxExpr = toVeloxExpr(sExpr.literal());


nit: return here directly?

Fixed the cases like this.

pedroerp · 2022-03-03T01:17:21Z

velox/substrait/SubstraitToVeloxExpr.h

+  /// name.
+  std::unordered_map<uint64_t, std::string> functionMap_;
+  /// This class contains the needed infos for Filter Pushdown.
+  class FilterInfo;


do we need to declare this class here? Seems like we could get away with just defining it as a free class in the .cpp file.

Removed the declaration from header.

pedroerp · 2022-03-03T01:17:52Z

velox/substrait/SubstraitToVeloxExpr.cpp

+// TODO: Support different types here.
+class SubstraitVeloxExprConverter::FilterInfo {
+ public:
+  FilterInfo() {}


nit: no need to explicitly specify it in this case

Fixed the cases like this.

pedroerp · 2022-03-03T01:25:23Z

velox/substrait/SubstraitToVeloxExpr.h

+  /// the relation key words, including AND, OR, and etc. Currently, only
+  /// AND is supported. This function is used to extract all the Substrait
+  /// conditions in the binary tree structure into a vector.
+  void getFlatConditions(


nit: maybe flattenConditions() could be more descriptive

pedroerp · 2022-03-03T01:27:59Z

velox/substrait/SubstraitToVeloxExpr.h

+      const int32_t& inputPlanNodeId);
+
+  /// Used to convert Substrait Filter into Velox SubfieldFilters.
+  connector::hive::SubfieldFilters toVeloxFilter(


I'm a bit confused not. If this class only converts expressions, shouldn't filter conversion be handled by the plan conversion api in the other file?

Yes, the filter conversion will be used in TableScan, so it is actually related to the plan conversion. Moved this part into the plan converter.

pedroerp · 2022-03-03T01:30:11Z

Thanks for addressing the comments! Just made a few more smaller comments here and there, but my main question is about where we place the filter conversion code.

jacques-n · 2022-03-03T16:02:05Z

velox/substrait/SubstraitToVeloxPlan.h

+
+  /// The map storing the relations between the function id and the function
+  /// name. Will be constructed based on the Substrait representation.
+  std::unordered_map<uint64_t, std::string> functionMap_;


This pattern of a function map doesn't seem to correctly represent the variability possible in a Substrait plan. How is this map constructed? It should be done by reading specific other parts of the plan.

Yes, I think we need to follow your suggestion to construct the function name into below format:

<function name>:<short_arg_type0><short_arg_type1>..._<short_arg_typeN>

And on your opinion, when should we validate those functions based on yaml specifications? In Spark or in Velox? I think we need to validate them before starting the computing.

rui-mo · 2022-03-03T16:02:10Z

Pushed one commit to fix the issues mentioned above. For the next, we will change the used function key words to be aligned with the specifications in Substrait yaml files.
The related function names are:
"AND", "SUM", "MULTIPLY", "LESS_THAN", "LESS_THAN_OR_EQUAL",, "GREATER_THAN_OR_EQUAL", "IS_NOT_NULL".
For those Substrait does not have yet, we will raise a PR to Substrait to add them.

pedroerp · 2022-03-03T17:38:05Z

velox/substrait/tests/PlanConversionTest.cpp

+  }
+};
+
+// This test will firstly generate mock TPC-H lineitem ORC file. Then, Velox's


Overall, this test suite has quite a lot of dependencies. Would it be possible to have a leaner test suite with multiple smaller cases exercising only the plan and expr conversion code?

My point being that we don't necessarily need to execute the full query here, but rather just test that given an input substrait plan/expr, it generates the expect Velox plan/expr. Verifying that Velox correctly executes a given Velox plan/expr is already covered by other test suites.

We could also build e2e tests like this one, but my suggestion would be to add this along other tpch test execution code.

Thanks for your insightful comments.
This is just our first PR. Later, my colleagues and I will submit a series of PRs to improve the UT and add more function support. This UT ensures that the subsequent PRs would not break the functionalities currently supported. We plan to add the UTs you mentioned in our following PRs.

pedroerp

Pheeew, getting there! A few more comments:

pedroerp · 2022-03-04T22:28:06Z

velox/substrait/SubstraitUtils.h

+
+namespace facebook::velox::substrait {
+
+/// This class contains some common funcitons used to parse Substrait


pedroerp · 2022-03-04T22:29:47Z

velox/substrait/SubstraitUtils.h

+  struct SubstraitType {
+    std::string type;
+    bool nullable;
+    SubstraitType(const std::string& subType, const bool& subNullable) {


use constructor intializers? Also, you might not need to explicitly specify this constructor - it's available by default (SubstraitType{a, b} type).

pedroerp · 2022-03-04T22:30:36Z

velox/substrait/SubstraitUtils.h

+  /// from a pre-constructed function map.
+  std::string findSubstraitFunction(
+      const std::unordered_map<uint64_t, std::string>& functionMap,
+      const uint64_t& id) const;


you can just pass primitive types by value.

Fixed the cases like this.

pedroerp · 2022-03-04T22:30:47Z

velox/substrait/SubstraitUtils.h

+  /// from a pre-constructed function map.
+  std::string findVeloxFunction(
+      const std::unordered_map<uint64_t, std::string>& functionMap,
+      const uint64_t& id) const;


pedroerp · 2022-03-04T22:31:38Z

velox/substrait/SubstraitUtils.h

+  /// words. Key: the Substrait function key word, Value: the Velox function key
+  /// word.
+  const std::unordered_map<std::string, std::string> substraitVeloxFunctionMap =
+      {{"MULTIPLY", "multiply"}, {"SUM", "sum"}};


will we need to add a mapping to every function available in Velox here at some point?

For those functions with different names in Substrait and Velox, a mapping relation is needed. Since we change to use the unified function names with Substrait, the two mapping relations here are not needed any more. Because in Substrait, they are also specified as "multiply" and "sum".

pedroerp · 2022-03-04T22:39:47Z

velox/substrait/SubstraitToVeloxPlan.h

+  std::shared_ptr<const core::PlanNode> toVeloxPlan(
+      const ::substrait::FilterRel& sFilter);
+
+  /// Used to convert Substrait ReadRel into Velox PlanNode.


can we explain what the parameters below mean?

Added explanation for them.

pedroerp · 2022-03-04T22:41:55Z

velox/substrait/SubstraitToVeloxPlan.h

+  }
+
+  /// Will add the paths of the files to be scanned into a vector.
+  void getPaths(std::vector<std::string>& paths) {


perhaps a more idiomatic way to achieve this is to have a function exposing the path_ vector as a const ref, and if you need to reuse this pattern inside the .cpp, this could be a free function inside an anonymous namespace on that file?

Thanks for your advice.
Actually these methods are called outside the .cpp, and in this PR, they are called in the UT. Changed them to expose the vector as a const ref.

pedroerp · 2022-03-04T22:43:39Z

velox/substrait/SubstraitToVeloxPlan.cpp

+    auto groupingExprs = grouping.grouping_expressions();
+    for (const auto& groupingExpr : groupingExprs) {
+      auto fieldExpr =
+          exprConverter_->toVeloxExpr(groupingExpr, inputPlanNodeId);


can we make the function return the specialized type directly (core::FieldAccessTypedExpr) so we don't need the cast below?

Fixed in this way.

pedroerp · 2022-03-04T22:44:03Z

velox/substrait/SubstraitToVeloxPlan.cpp

+  std::vector<std::string> projectOutNames;
+  std::vector<std::shared_ptr<const core::CallTypedExpr>> aggExprs;
+  aggExprs.reserve(sAgg.measures().size());
+  // Construct Velox Aggregate expressions.


nit: maybe use a blank line to separate code blocks?

pedroerp · 2022-03-04T22:45:49Z

velox/substrait/SubstraitToVeloxPlan.cpp

+std::shared_ptr<const core::PlanNode> SubstraitVeloxPlanConverter::toVeloxPlan(
+    const ::substrait::RelRoot& sRoot) {
+  const auto& sNames = sRoot.names();
+  int nameIdx = 0;


int nameIdx = sNames.size();

?

Removed. It is not used currently.

pedroerp

Thanks for iterating on this diff. There will likely be more improvements needed, but let's get this in and improve as we go.

Thanks for the contribution!

facebook-github-bot · 2022-03-10T00:25:31Z

@pedroerp has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

rui-mo · 2022-03-10T05:29:58Z

Hi @pedroerp, thanks for your approval.
I note Facebook Internal - Linter reported 1 warning & 2 advices for my PR, but I cannot see the details due to lacking the permission. Do I need to fix them? If so, could you expose some details?

pedroerp · 2022-03-10T21:19:38Z

Hi @pedroerp, thanks for your approval. I note Facebook Internal - Linter reported 1 warning & 2 advices for my PR, but I cannot see the details due to lacking the permission. Do I need to fix them? If so, could you expose some details?

No worries, I'll have to add the internal building details, so I can take care of the linter warning. Thanks again for looking into this!

Summary: This pr is targeted to add the base layout for Substrait-to-Velox conversion. With this change, the base layout of Substrait-to-Velox conversion would be decided. Some of Substrait plan representations can be converted into Velox plan for computing. More conversions support will be added in following pull requests. Based on [Substrait Commit](substrait-io/substrait@9d9805b). The used function names are based on: [Substrait PR](substrait-io/substrait#147). Pull Request resolved: facebookincubator#1048 Reviewed By: kagamiori Differential Revision: D34773052 Pulled By: pedroerp fbshipit-source-id: c4c56a43486519b567aa1d715a0d64ce02a447d1

rui-mo marked this pull request as draft February 15, 2022 11:56

rui-mo added 2 commits February 21, 2022 13:08

add Substrait to Velox conversion

f5b6e5c

solve compiling issues and add a unit test

461b040

rui-mo force-pushed the wip_substrait branch from a2ee0f8 to 461b040 Compare February 22, 2022 01:54

rui-mo added 2 commits February 23, 2022 20:42

solve build and compiling issues

e472ee1

use json file and generate test data

c88bc3d

rui-mo force-pushed the wip_substrait branch from 3f7338f to f37da8f Compare February 24, 2022 04:10

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 24, 2022

update Substrait and solve Github checking issues

c379e39

rui-mo force-pushed the wip_substrait branch from f37da8f to c379e39 Compare February 24, 2022 09:18

fix format and UT test

fb96bf9

rui-mo force-pushed the wip_substrait branch from 32ed8d8 to fb96bf9 Compare February 24, 2022 11:06

rui-mo marked this pull request as ready for review February 24, 2022 11:23

pedroerp reviewed Feb 25, 2022

View reviewed changes

rui-mo force-pushed the wip_substrait branch 2 times, most recently from 9da443b to 5a8d146 Compare March 2, 2022 12:18

code improvement according to comments

661ed96

rui-mo force-pushed the wip_substrait branch from 5a8d146 to 661ed96 Compare March 2, 2022 12:40

pedroerp reviewed Mar 3, 2022

View reviewed changes

code improvement

cf5855d

rui-mo force-pushed the wip_substrait branch from 34c9e0a to cf5855d Compare March 3, 2022 15:36

jacques-n reviewed Mar 3, 2022

View reviewed changes

pedroerp reviewed Mar 3, 2022

View reviewed changes

pedroerp reviewed Mar 4, 2022

View reviewed changes

rui-mo added 2 commits March 7, 2022 17:28

code improvement according to comments

2f66ace

use unified function names

a260134

rui-mo force-pushed the wip_substrait branch from 9c1f57b to a260134 Compare March 7, 2022 10:13

pedroerp approved these changes Mar 10, 2022

View reviewed changes

facebook-github-bot closed this in 2ed40db Mar 11, 2022

mbasmanova mentioned this pull request Apr 12, 2022

Add velox-to-substrait converter #1212

Closed

JkSelf mentioned this pull request May 24, 2022

[Substrait-to-Velox] Capture the file format specified in Substrait plan #1683

Closed

rui-mo pushed a commit to rui-mo/velox that referenced this pull request Mar 17, 2023

[Gluten-core] Add struct literal support (facebookincubator#1048)

6a68e8c

rui-mo deleted the wip_substrait branch February 20, 2024 03:14


		namespace facebook::velox::substrait {

		/// This class contains some common funcitons used to parse Substrait

Add Substrait-to-Velox conversion #1048

Add Substrait-to-Velox conversion #1048

Conversation

rui-mo commented Feb 15, 2022 • edited Loading

facebook-github-bot commented Feb 15, 2022

Action Required

Process

pedroerp commented Feb 17, 2022

rui-mo commented Feb 18, 2022 • edited Loading

jacques-n commented Feb 20, 2022

rui-mo commented Feb 22, 2022 • edited Loading

winningsix commented Feb 23, 2022

jacques-n commented Feb 23, 2022

winningsix commented Feb 23, 2022

jacques-n commented Feb 23, 2022

rui-mo commented Feb 23, 2022

facebook-github-bot commented Feb 24, 2022

rui-mo commented Feb 25, 2022

pedroerp left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rui-mo Mar 2, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rui-mo Mar 2, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rui-mo Mar 2, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rui-mo Mar 2, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedroerp commented Mar 3, 2022

Choose a reason for hiding this comment

rui-mo Mar 4, 2022 • edited Loading

Choose a reason for hiding this comment

rui-mo commented Mar 3, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedroerp left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rui-mo commented Feb 15, 2022 •

edited

Loading

rui-mo commented Feb 18, 2022 •

edited

Loading

rui-mo commented Feb 22, 2022 •

edited

Loading

rui-mo Mar 2, 2022 •

edited

Loading

rui-mo Mar 2, 2022 •

edited

Loading

rui-mo Mar 2, 2022 •

edited

Loading

rui-mo Mar 2, 2022 •

edited

Loading

rui-mo Mar 4, 2022 •

edited

Loading

rui-mo commented Mar 3, 2022 •

edited

Loading