-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add string function test cases #4
Conversation
25a1712
to
9c13219
Compare
The postgres does not support negative start positions for |
2cdb0b5
to
3e03141
Compare
1de58ae
to
7acb9db
Compare
7acb9db
to
f86901f
Compare
f86901f
to
78db3b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's mark pyvelox as unsupported for like for now and we can add a "requires_constant" option later when they come up with a newer release.
Let's open an issue for this before we merge this.
Let's make another PR to add a new option to substrait specifying behavior of negative start for substring. Choices are:
- Wrap from the end (duckdb, sqlite?)
- Go left past the beginning (postgres)
- Throw an error (???)
For this PR maybe update the substring function to have some examples of each and use required_options similar to how we handle overflow in addition.
9be5c62
to
0abb80e
Compare
|
No description provided.