test: use i32 and i64 substring args for postgres vs velox

substrait-io · May 31, 2023 · 1de58ae · 1de58ae
1 parent ad4dc33
commit 1de58ae
Show file tree

Hide file tree

Showing 3 changed files with 54 additions and 0 deletions.
diff --git a/cases/string/substring.yaml b/cases/string/substring.yaml
@@ -3,6 +3,17 @@ cases:
   - group:
       id: basic
       description: Basic examples without any special cases
+    args:
+      - value: 'abcdefg'
+        type: string
+      - value: 1
+        type: i32
+      - value: 5
+        type: i32
+    result:
+      value: 'abcde'
+      type: string
+  - group: basic
     args:
       - value: 'abcdefg'
         type: string
@@ -16,6 +27,17 @@ cases:
   - group:
       id: negative_start
       description: Example where start argument is a negative integer
+    args:
+      - value: 'abcdefg'
+        type: string
+      - value: -3
+        type: i32
+      - value: 2
+        type: i32
+    result:
+      value: 'ef'
+      type: string
+  - group: negative_start
     args:
       - value: 'abcdefg'
         type: string
@@ -29,6 +51,17 @@ cases:
   - group:
       id: start_greater_than_length
       description: Example where start argument greater than the length of the string
+    args:
+      - value: 'abcdefg'
+        type: string
+      - value: 10
+        type: i32
+      - value: 2
+        type: i32
+    result:
+      value: ''
+      type: string
+  - group: start_greater_than_length
     args:
       - value: 'abcdefg'
         type: string
@@ -42,6 +75,17 @@ cases:
   - group:
       id: multi_byte_characters
       description: Example where multi byte characters exist in the string
+    args:
+      - value: '😊a😊b😊😊'
+        type: string
+      - value: 1
+        type: i32
+      - value: 3
+        type: i32
+    result:
+      value: '😊a😊'
+      type: string
+  - group: multi_byte_characters
     args:
       - value: '😊a😊b😊😊'
         type: string

diff --git a/dialects/postgres.yaml b/dialects/postgres.yaml
@@ -219,6 +219,11 @@ scalar_functions:
           - i32
         result: fp64
   - name: substring
+    unsupported_kernels:
+      - args:
+          - i64
+          - i64
+        result: string
   - name: concat
     local_name: "||"
     infix: True

diff --git a/dialects/velox_presto.yaml b/dialects/velox_presto.yaml
@@ -287,5 +287,10 @@ scalar_functions:
         result: fp64
   - name: substring
     local_name: substr
+    unsupported_kernels:
+      - args:
+          - i32
+          - i32
+        result: string
   - name: concat
   - name: like