Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix for IDN domains" #2

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Revert "Fix for IDN domains" #2

merged 1 commit into from
Jul 21, 2023

Conversation

subregular
Copy link
Owner

Reverts #1

Need to redo the root domain identification, with the option of internationalized domain names.

if the domain is indeed an IDN.
if there is an "idn" application in the system.
Possible to do with acme.sh built-in function "_idn() "

@subregular subregular merged commit ce43778 into main Jul 21, 2023
@dyadMisha
Copy link

totally agree, but meanwhile if someone search for a solution, here is the quick and dirty fix that worked for me.

@subregular subregular deleted the revert-1-bugfix/idn branch July 24, 2023 11:04
@subregular
Copy link
Owner Author

subregular commented Aug 11, 2023

totally agree, but meanwhile if someone search for a solution, here is the quick and dirty fix that worked for me.

The dns_rm function is not working correctly with your patch. Records are not deleted if the root domain is IDN.
The latest version of the script is fixed and tested with IDN and regular domains.
I would be grateful for testing.

p.s.
There are more scripts for acme.sh:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants