Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Yandex PDD api with Yandex360 api #4599

Closed
wants to merge 2 commits into from

Conversation

ProKn1fe
Copy link

Old Yandex PDD api was deprecated and replaced with Yandex360 api (more info #4555).

@github-actions
Copy link

Welcome
Please make sure you're read our DNS API Dev Guide and DNS-API-Test.
Then reply on this message, otherwise, your code will not be reviewed or merged.
We look forward to reviewing your Pull request shortly ✨

@ProKn1fe
Copy link
Author

Welcome Please make sure you're read our DNS API Dev Guide and DNS-API-Test. Then reply on this message, otherwise, your code will not be reviewed or merged. We look forward to reviewing your Pull request shortly ✨

I have only one question i should update existing yandex pdd wiki item or create new? It will broke sequence because it must be removed due to complete inaccessible.

@DrySock
Copy link

DrySock commented May 23, 2023

Waiting for this merge

@wolf4914
Copy link

wolf4914 commented May 23, 2023

So I renamed the old one to old and put the new 360 script in /dnsapi but still get an error though: Can not find dns api hook for: dns_yandex
You need to add the txt record manually.
Add the following TXT record: blah-blah
acme.sh --renew --dns dns_yandex -d '*.vadim.com.ru' -d vadim.com.ru --dnssleep3600 and the dnssleep does not work for the countdown either

@Neilpang
Copy link
Member

@WhiteAls
Copy link
Contributor

WhiteAls commented May 26, 2023

So I renamed the old one to old and put the new 360 script in /dnsapi but still get an error though: Can not find dns api hook for: dns_yandex You need to add the txt record manually. Add the following TXT record: blah-blah acme.sh --renew --dns dns_yandex -d '*.vadim.com.ru' -d vadim.com.ru --dnssleep3600 and the dnssleep does not work for the countdown either

  1. Yandex DNS API name has been changed. The new value for the --dns argument must now be set as dns_yandex360.
  2. You must issue a new token for the updated Yandex API. Please refer to this guide for more information: https://yandex.ru/dev/api360/doc/concepts/access.html

If you have any questions, please refrain from asking them in the pull request body. Instead, kindly refer to the corresponding issue #4555 for further assistance

@ProKn1fe
Copy link
Author

fix the dns test first: https://github.com/acmesh-official/acme.sh/wiki/DNS-API-Test

What should be fixed? I don't see yandex pdd tests in current DNS.yml

@WhiteAls
Copy link
Contributor

What should be fixed? I don't see yandex pdd tests in current DNS.yml

You need to run these tests on your own in your forked repository. Just follow all the instructions provided in the attached link.
Also, did you read this? https://github.com/acmesh-official/acme.sh/wiki/DNS-API-Dev-Guide

@ProKn1fe
Copy link
Author

What should be fixed? I don't see yandex pdd tests in current DNS.yml

You need to run these tests on your own in your forked repository. Just follow all the instructions provided in the attached link. Also, did you read this? https://github.com/acmesh-official/acme.sh/wiki/DNS-API-Dev-Guide

And what if i no more have domain with this api to test?

@ProKn1fe
Copy link
Author

I have no more domains in yandex360, so i can't test it.

@ProKn1fe ProKn1fe closed this Jan 27, 2024
@dimmik80
Copy link

Hello. I would like to resume this topic. Tell me what needs to be done to make a merge?

@WhiteAls
Copy link
Contributor

Hello. I would like to resume this topic. Tell me what needs to be done to make a merge?

The issue has been addressed in pull request #5214, so merging that should resolve the problem #4555.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants