Separate biome's configuration command and arguments
#9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchl
reviewed
Dec 7, 2023
PR #7 made `biome` work on Windows through a `cmd.exe` shim. That, however, had an unforeseen consequence of leaving Node runtime processes (and their console hosts) orphaned when their parent `cmd.exe` process got terminated. This commit adapts the approach employed by e.g. LSP-volar instead.
rchl
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #7 made
biomework on Windows through acmd.exeshim. That, however, had an unforeseen consequence of leaving Node runtime processes (and their console hosts) orphaned when their parentcmd.exeprocess got terminated.This commit adapts the approach employed by e.g. LSP-volar instead.