Fix biome's entry point resolution on Windows
#7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`biome` is a shell script that Windows can't run on its own:
[WinError 193] %1 is not a valid Win32 application
This commit makes LSP-biome point to `biome.cmd` on Windows instead.
rchl
approved these changes
Dec 6, 2023
|
Thanks |
|
How does this work? I thought sublime.platform was a function, not a global property? |
|
I don't believe comparing strings to functions is the intended behavior |
|
Oops, you're right - I somehow messed that up when I was moving the changes from my local copy... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
biomeis a shell script that Windows can't run on its own:This commit makes LSP-biome point to
biome.cmdon Windows instead.