Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the version to 1.4.0 #95

Merged
merged 5 commits into from
Oct 14, 2021
Merged

Bump the version to 1.4.0 #95

merged 5 commits into from
Oct 14, 2021

Conversation

kienstra
Copy link
Contributor

@kienstra kienstra commented Oct 12, 2021

Changes

  • Bumps the version to 1.4.0 to prepare for the release on Thursday, October 14th
  • Adds a CHANGELOG entry.
  • Bumps the minimum WP version to 5.7

Testing instructions

  1. php bin/verify-versions.php
  2. Expected: 'Success! All of the version numbers are the same, and there's a CHANGELOG.md entry.'

CHANGELOG.md Outdated
@@ -1,5 +1,12 @@
## Changelog ##

### 1.4.0 - 2021-10-14 ###

Add a modal option to make longer blocks easier, fix for widgets.php

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe missing a * at the start of this line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I deleted that line in 060cee3.

That was intended to be a summary. But there are only 2 bullet points below it. No summary needed 😄

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah I see! Sorry I'm a bit new to proper changelog formatting :D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh all good, it looked awkward having a summary almost as long as the 2 bullet points combined.

Like Jen mentioned,
this isn't fixed.
@kienstra
Copy link
Contributor Author

If it's alright, I removed the line about the widgets.php fix, as #94 isn't ready.

@kienstra kienstra merged commit 4a10aef into develop Oct 14, 2021
@kienstra kienstra deleted the bump/1.4.0 branch October 14, 2021 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants