Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ServerSideRender in /wp-admin/widgets.php #94

Closed
wants to merge 11 commits into from

Conversation

kienstra
Copy link
Contributor

@kienstra kienstra commented Sep 17, 2021

Changes

  • Fixes a ServerSideRender error in /wp-admin/widgets.php:

widget-blocke-editor

{"code":"rest_invalid_param","message":"Invalid parameter(s): attributes","data":{"status":400,"params":{"attributes":"__internalWidgetId is not a valid property of Object."}
  • It looks like useBlockProps() takes care of this.

Fixes GF-3214

Testing instructions

There was an error:
{"code":"rest_invalid_param","message":"Invalid parameter(s): attributes","data":{"status":400,"params":{"attributes":"__internalWidgetId is not a valid property of Object."}
Before, this didn't export
the store.
@kienstra kienstra marked this pull request as ready for review September 18, 2021 00:51
@kienstra kienstra changed the title Bump server-side-render to the latest Fix ServerSideRender in /wp-admin/widgets.php Sep 18, 2021
Copy link
Contributor

@dreamwhisper dreamwhisper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, I'm still experiencing the original error on the widgets screen with both old and new custom blocks. Still looking into it.

@kienstra
Copy link
Contributor Author

@dreamwhisper,
OK, thanks a lot for testing this.

@kienstra
Copy link
Contributor Author

@dreamwhisper,
You're right, this PR doesn't fix it. I'm going to punt this until a later release.

@kienstra kienstra closed this Aug 9, 2022
@kienstra kienstra deleted the fix/ssr-error-widgets-php branch July 27, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants