Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix eslint violations #559

Merged
merged 1 commit into from
Nov 15, 2019
Merged

chore: fix eslint violations #559

merged 1 commit into from
Nov 15, 2019

Conversation

nabdelgadir
Copy link
Contributor

Fix comma-dangle violations

Description

Related issues

  • connect to <link_to_referenced_issue>

Checklist

  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide

@nabdelgadir
chore: fix eslint violations
1c77b92 
Fix comma-dangle violations
@nabdelgadir nabdelgadir self-assigned this Nov 15, 2019
@nabdelgadir nabdelgadir mentioned this pull request Nov 15, 2019
Merged
2 tasks
dhmlau
dhmlau approved these changes Nov 15, 2019
View reviewed changes
Copy link
Member

@dhmlau dhmlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nabdelgadir !

@nabdelgadir
Copy link
Contributor Author

@slnode test please

@nabdelgadir nabdelgadir merged commit 7a5921b into master Nov 15, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix-comma-dangle branch November 15, 2019 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhmlau dhmlau dhmlau approved these changes

@rashmihunt rashmihunt Awaiting requested review from rashmihunt rashmihunt is a code owner

Assignees

@nabdelgadir nabdelgadir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nabdelgadir @dhmlau