Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add openapi and grpc to available connectors #558

Merged
merged 1 commit into from
Nov 19, 2019
Merged

feat: add openapi and grpc to available connectors #558

merged 1 commit into from
Nov 19, 2019

Conversation

nabdelgadir
Copy link
Contributor

Description

Add loopback-connector-openapi and loopback-connector-grpc to available connectors.

Related issues

Checklist

  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide

@nabdelgadir nabdelgadir self-assigned this Nov 15, 2019
@nabdelgadir
Copy link
Contributor Author

CI failures are due to linter violations (fixed by #559).

dhmlau
dhmlau approved these changes Nov 15, 2019
View reviewed changes
Copy link
Member

@dhmlau dhmlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tried to run against the new changes, but the changes look reasonable to me.

@nabdelgadir nabdelgadir force-pushed the add-grpc-openapi branch 2 times, most recently from 60c1e25 to ea14ba1 Compare November 15, 2019 23:26
bajtos
bajtos approved these changes Nov 18, 2019
View reviewed changes
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@nabdelgadir nabdelgadir merged commit 11a08d5 into master Nov 19, 2019
@delete-merged-branch delete-merged-branch bot deleted the add-grpc-openapi branch November 19, 2019 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhmlau dhmlau dhmlau approved these changes

@bajtos bajtos bajtos approved these changes

@rashmihunt rashmihunt Awaiting requested review from rashmihunt rashmihunt is a code owner

Assignees

@nabdelgadir nabdelgadir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nabdelgadir @bajtos @dhmlau