Report initialization errors to Sentry from main #173
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Similar to #172, except this doesn't require resolving #133 before merging.
If we encounter fatal errors when initializing Veneur, we should send those to Sentry (if possible), rather than (just) logging them.
Motivation
See #172
Test plan
Tested locally by providing a bad configuration:
Rollout/monitoring/revert plan
r? @stripe/observability