Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report initialization errors to Sentry from main #173

Merged
merged 1 commit into from
Aug 29, 2017

Conversation

ChimeraCoder
Copy link
Contributor

@ChimeraCoder ChimeraCoder commented Jun 12, 2017

Summary

Similar to #172, except this doesn't require resolving #133 before merging.

If we encounter fatal errors when initializing Veneur, we should send those to Sentry (if possible), rather than (just) logging them.

Motivation

See #172

Test plan

Tested locally by providing a bad configuration:

$ go build && ./veneur -f ../../example.yaml
INFO[0000] Preparing workers                             number=2
ERRO[0000] Error initializing server                     error=address h::::: too many colons in address
FATA[0010] Could not initialize server                   error=address h::::: too many colons in address

Rollout/monitoring/revert plan

r? @stripe/observability

@aditya-stripe
Copy link
Contributor

r? @stripe/observability

@joshu-stripe
Copy link
Contributor

:shipit:!

@cory-stripe
Copy link
Contributor

Hey @aditya-stripe, this needs a rebase then we can merge!

@aditya-stripe aditya-stripe force-pushed the aditya-report-sentry branch from 43b2a40 to c75fcd2 Compare June 29, 2017 18:37
@stripe-ci
Copy link

Gerald Rule: Copy Observability on Veneur and Unilog pull requests

cc @stripe/observability
cc @stripe/observability-stripe

@cory-stripe
Copy link
Contributor

Hrm, was gonna merge this but getting a test failure on tip that miiiight be transient…

@cory-stripe cory-stripe force-pushed the aditya-report-sentry branch from 8d6f86f to 529a4df Compare August 29, 2017 15:24
@cory-stripe cory-stripe merged commit 9585d29 into master Aug 29, 2017
@cory-stripe cory-stripe deleted the aditya-report-sentry branch August 29, 2017 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants