Report initialization errors to Sentry before exiting #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Nice! Unsure why this is failing as the builds all expired. :) |
aditya-stripe
force-pushed
the
aditya-initialization-monitor
branch
from
7a034d9 to
1d5be79
Compare
Gerald Rule: Copy Observability on Veneur and Unilog pull requestscc @stripe/observability |
aditya-stripe
force-pushed
the
aditya-initialization-monitor
branch
from
1d5be79 to
b2aaf53
Compare
aditya-stripe
force-pushed
the
aditya-initialization-monitor
branch
from
b2aaf53 to
c13923c
Compare
|
re-r? @cory-stripe |
|
👍 (assuming builds work) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If we encounter errors when initializing Veneur, we should send those to Sentry (if possible), rather than (just) logging them.
Motivation
Monitoring Veneur failures is a fun problem - we can't use statsd, because Veneur won't be around for another 10 seconds to report its error (if it is even capable of reporting it in the first place). We don't have Sentry configured in
cmd/veneur, and doing so would be pretty inconvenient for a rather dubious reward.The tests here are currently failing, and will continue to do so until #133 is fixed and merged.
An alternative approach would be to export the Raven client from the Veneur package so that
cmd/veneuris able to report the error. I'm doing that separately, but I think that's suboptimal, because it means we're essentially duplicating the logic in two places.Test plan
Rollout/monitoring/revert plan
r? @cory-stripe
cc @stripe/observability