Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @brandur-stripe
cc @stripe/api-libraries
(This is for the upcoming v2.0.)
Update setup.py and test flow:
refactor
setup.py
to use best practices described in https://github.com/pypa/sampleproject/blob/master/setup.pybump minimum
requests
version to 2 (current major version)add
requests[security]
to dependencies for Python 2. This should help with TLS 1.2 issues, e.g. when using the default OS X Python interpreter.removed
pytest-runner
fromsetup_requires
to avoid installing the package for everysetup.py
invocation. Instead use a customPyTest
command as described here.use
pytest-xdist
to distribute tests over multiple cores. This is not very useful when running tests on a reasonably powerful local machine, but gives a noticeable speed increase on Travis.use
find_packages
to discover packages automaticallyGreatly simply
tox.ini
by putting coverage and flake8 configurations in dedicateds files, and simply runningpython setup.py test
Don't install
pycurl
package when running tests as it wasn't actually used anywhereRemove
allow_failures
from Travis configuration as we probably want to not merge PRs that break PyPy or 3.7 compatibility