stripe-python 2.0.0 #386
stripe-python 2.0.0 #386
Conversation
ob-stripe
force-pushed
the
integration-v2
branch
3 times, most recently
from
b092152 to
47ac3a7
Compare
ob-stripe
force-pushed
the
integration-v2
branch
4 times, most recently
from
4dbab1f to
72d75be
Compare
ob-stripe
force-pushed
the
integration-v2
branch
3 times, most recently
from
f18389d to
e91e9d2
Compare
Makefile
Outdated
| pipenv run detox | ||
|
|
||
| ci: | ||
| pipenv run py.test --cov=stripe -n 8 |
There was a problem hiding this comment.
The preferred name is just "pytest" (also above).
There was a problem hiding this comment.
👍 Thanks! Will fix.
| pytest-cov = ">=2.5" | ||
| tox = "*" | ||
| detox = "*" | ||
| "flake8" = "*" |
There was a problem hiding this comment.
Does "flake8" need to be quoted?
There was a problem hiding this comment.
Good question! I'm not entirely sure why pipenv wraps some package names in quotes, but I figure it knows what it's doing :)
There was a problem hiding this comment.
It doesn't need to be quoted (source: https://github.com/toml-lang/toml#keys), but pipenv's toml library (prettytoml) is a bit overzealous and quotes any package name with a digit in it.
tox.ini
Outdated
| basepython = python2.7 | ||
| deps = flake8 | ||
| commands = python -m flake8 --show-source stripe setup.py {posargs} | ||
| python -m flake8 --show-source tests {posargs} |
There was a problem hiding this comment.
Could be a single command (moving/including tests to/with the first).
ob-stripe
force-pushed
the
integration-v2
branch
2 times, most recently
from
50cad57 to
7437d29
Compare
ob-stripe
force-pushed
the
integration-v2
branch
2 times, most recently
from
7591929 to
7730ec8
Compare
ob-stripe
force-pushed
the
integration-v2
branch
3 times, most recently
from
929407f to
1870900
Compare
ob-stripe
force-pushed
the
integration-v2
branch
from
1870900 to
f5f46c0
Compare
ob-stripe
force-pushed
the
integration-v2
branch
from
f5f46c0 to
cf93aff
Compare
ob-stripe
force-pushed
the
integration-v2
branch
2 times, most recently
from
7c7f891 to
54a9675
Compare
|
r? @brandur-stripe Alright, I think this is ready to be released. All PRs included in this branch have already been approved. Let me know if you have any concerns. |
|
Very exciting :) LGTM. |
|
🎉 |
|
Alrighty, let's go :) |
util.jsonand usejsonmodule directly everywhere (Remove util.json and use json module directly everywhere #402)setup.pyand test flow (Update setup.py and test flow #403)NotImplementedErrortostripe.error.InvalidRequestError(Change exception type when detaching unattached sources to InvalidRequestError #415)Fixes #376.