Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PHPDoc on nested resources #857

Merged
merged 1 commit into from
Feb 4, 2020
Merged

Update PHPDoc on nested resources #857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/ApplicationFeeRefund.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
* @property int $created
* @property string $currency
* @property string $fee
* @property StripeObject $metadata
* @property \Stripe\StripeObject $metadata
*
* @package Stripe
*/
Expand Down
2 changes: 1 addition & 1 deletion lib/Capability.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
* @property string $account
* @property bool $requested
* @property int $requested_at
* @property mixed $requirements
* @property \Stripe\StripeObject $requirements
* @property string $status
*/
class Capability extends ApiResource
Expand Down
2 changes: 1 addition & 1 deletion lib/Collection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
* @property string $object
* @property string $url
* @property bool $has_more
* @property mixed $data
* @property \Stripe\StripeObject[] $data
*
* @package Stripe
*/
Expand Down
2 changes: 1 addition & 1 deletion lib/CustomerBalanceTransaction.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
* @property int $ending_balance
* @property string $invoice
* @property bool $livemode
* @property StripeObject $metadata
* @property \Stripe\StripeObject $metadata
* @property string $type
*/
class CustomerBalanceTransaction extends ApiResource
Expand Down
6 changes: 3 additions & 3 deletions lib/InvoiceLineItem.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@
* @property bool $discountable
* @property string $invoice_item
* @property bool $livemode
* @property StripeObject $metadata
* @property mixed $period
* @property Plan $plan
* @property \Stripe\StripeObject $metadata
* @property \Stripe\StripeObject $period
* @property \Stripe\Plan $plan
* @property bool $proration
* @property int $quantity
* @property string $subscription
Expand Down
36 changes: 18 additions & 18 deletions lib/Person.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,28 +10,28 @@
* @property string $id
* @property string $object
* @property string $account
* @property mixed $address
* @property mixed $address_kana
* @property mixed $address_kanji
* @property \Stripe\StripeObject $address
* @property \Stripe\StripeObject|null $address_kana
* @property \Stripe\StripeObject|null $address_kanji
* @property int $created
* @property bool $deleted
* @property mixed $dob
* @property string $email
* @property string $first_name
* @property string $first_name_kana
* @property string $first_name_kanji
* @property string $gender
* @property \Stripe\StripeObject $dob
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't this be null? IF not is it a weird hash with January 1 1970?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not according to the spec, but I think the spec may be wrong in this instance.

* @property string|null $email
* @property string|null $first_name
* @property string|null $first_name_kana
* @property string|null $first_name_kanji
* @property string|null $gender
* @property bool $id_number_provided
* @property string $last_name
* @property string $last_name_kana
* @property string $last_name_kanji
* @property string $maiden_name
* @property StripeObject $metadata
* @property string $phone
* @property mixed $relationship
* @property mixed $requirements
* @property string|null $last_name
* @property string|null $last_name_kana
* @property string|null $last_name_kanji
* @property string|null $maiden_name
* @property \Stripe\StripeObject $metadata
* @property string|null $phone
* @property \Stripe\StripeObject $relationship
* @property \Stripe\StripeObject|null $requirements
* @property bool $ssn_last_4_provided
* @property mixed $verification
* @property \Stripe\StripeObject $verification
*/
class Person extends ApiResource
{
Expand Down
4 changes: 2 additions & 2 deletions lib/RecipientTransfer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@
* @property string $failure_code
* @property string $failure_message
* @property bool $livemode
* @property StripeObject $metadata
* @property \Stripe\StripeObject $metadata
* @property string $method
* @property string $recipient
* @property mixed $reversals
* @property \Stripe\Collection $reversals
* @property bool $reversed
* @property string $source_type
* @property string $statement_descriptor
Expand Down
2 changes: 1 addition & 1 deletion lib/SourceTransaction.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@
*
* @property string $id
* @property string $object
* @property \Stripe\StripeObject $ach_credit_transfer
* @property int $amount
* @property int $created
* @property string $customer_data
* @property string $currency
* @property string $type
* @property mixed $ach_credit_transfer
*
* @package Stripe
*/
Expand Down
2 changes: 1 addition & 1 deletion lib/TaxId.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
* @property bool $livemode
* @property string $type
* @property string $value
* @property mixed $verification
* @property \Stripe\StripeObject $verification
*/
class TaxId extends ApiResource
{
Expand Down
2 changes: 1 addition & 1 deletion lib/TransferReversal.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
* @property int $created
* @property string $currency
* @property string $destination_payment_refund
* @property StripeObject $metadata
* @property \Stripe\StripeObject $metadata
* @property string $source_refund
* @property string $transfer
*
Expand Down
2 changes: 1 addition & 1 deletion lib/UsageRecordSummary.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
* @property string $object
* @property string $invoice
* @property bool $livemode
* @property mixed $period
* @property \Stripe\StripeObject $period
* @property string $subscription_item
* @property int $total_usage
*/
Expand Down