Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PHPDoc on nested resources #857

Merged
merged 1 commit into from
Feb 4, 2020
Merged

Update PHPDoc on nested resources #857

merged 1 commit into from
Feb 4, 2020

Conversation

ob-stripe
Copy link
Contributor

r? @remi-stripe
cc @stripe/api-libraries

Update PHPDoc on nested resources that are not being generated yet.

* @property int $created
* @property bool $deleted
* @property mixed $dob
* @property \Stripe\StripeObject $dob
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't this be null? IF not is it a weird hash with January 1 1970?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not according to the spec, but I think the spec may be wrong in this instance.

@stripe-ci stripe-ci removed the approved label Feb 4, 2020
@ob-stripe ob-stripe merged commit e860da1 into master Feb 4, 2020
@ob-stripe ob-stripe deleted the ob-remove-mixed branch February 4, 2020 04:28
@ob-stripe
Copy link
Contributor Author

Released as 7.23.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants