Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Updates #1257

Merged
merged 1 commit into from
Sep 24, 2021
Merged

API Updates #1257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/resources/GeneratedTests.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -768,8 +768,8 @@ describe('TaxId', function() {

it('retrieveTaxId method', async function() {
const taxId = await stripe.customers.retrieveTaxId(
'txi_xxxxxxxxxxxxx',
'cus_xxxxxxxxxxxxx'
'cus_xxxxxxxxxxxxx',
'txi_xxxxxxxxxxxxx'
Comment on lines +771 to +772
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmmmm....... maybe we have something non-deterministic here? 🤔 Seems unrelated to this...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not non-determinism -- this is the result of a minor bugfix: the correct ordering is [parentId, childId] and this had been called with the arguments in the wrong order.

);
expect(taxId).not.to.be.null;
});
Expand Down
10 changes: 10 additions & 0 deletions types/2020-08-27/Charges.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -918,6 +918,11 @@ declare module 'stripe' {
}

interface CardPresent {
/**
* The authorized amount
*/
amount_authorized: number | null;

/**
* Card brand. Can be `amex`, `diners`, `discover`, `jcb`, `mastercard`, `unionpay`, `visa`, or `unknown`.
*/
Expand Down Expand Up @@ -990,6 +995,11 @@ declare module 'stripe' {
*/
network: string | null;

/**
* Defines whether the authorized amount can be over-captured or not
*/
overcapture_supported: boolean | null;

/**
* How card details were read in this transaction.
*/
Expand Down