Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Updates #1257

Merged
merged 1 commit into from
Sep 24, 2021
Merged

API Updates #1257

merged 1 commit into from
Sep 24, 2021

Conversation

richardm-stripe
Copy link
Contributor

Codegen for openapi 8442a02.
r? @dcr-stripe
cc @stripe/api-libraries

Changelog

  • Add support for amount_authorized and overcapture_supported on Charge.payment_method_details.card_present

Copy link
Contributor

@dcr-stripe dcr-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment on lines +771 to +772
'cus_xxxxxxxxxxxxx',
'txi_xxxxxxxxxxxxx'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmmmm....... maybe we have something non-deterministic here? 🤔 Seems unrelated to this...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not non-determinism -- this is the result of a minor bugfix: the correct ordering is [parentId, childId] and this had been called with the arguments in the wrong order.

@richardm-stripe richardm-stripe merged commit 67e4ac0 into master Sep 24, 2021
@richardm-stripe richardm-stripe deleted the latest-codegen branch September 28, 2021 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants