Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#857 Allow default stripeAccount in options #1102

Merged
merged 2 commits into from
Jul 15, 2021

Conversation

lyndonbuckley
Copy link
Contributor

@lyndonbuckley lyndonbuckley commented Jan 1, 2021

This is a pretty minor code change allowing a new option in the StripeConfig interface stripeAccount
When building an API request, the Stripe-Account header is now added to the default request headers.

fixes #857

@CLAassistant
Copy link

CLAassistant commented Jan 1, 2021

CLA assistant check
All committers have signed the CLA.

@lyndonbuckley
Copy link
Contributor Author

lyndonbuckley commented Jan 1, 2021

fixes #857

@chase-moskal
Copy link

@richardm-stripe @remi-stripe

i'd really like to see this feature land -- otherwise it's too perilous to manually ensure large groups of stripe calls are attaching the correct {stripeAccount: "..."} option

things will be safer once we can preconfigure the stripe account header for whole systems, that way, none of the individual stripe calls can make such a simple mistake :)

Copy link
Contributor

@richardm-stripe richardm-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I took the liberty of writing a test in a separate PR and will hopefully merge both soon!

@lyndonbuckley
Copy link
Contributor Author

Thanks @richardm-stripe
I'll keep an eye on PR #1191 then

@richardm-stripe richardm-stripe merged commit 40eaaab into stripe:master Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Allow initializing the stripeAccount in options
4 participants