Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Allow initializing the stripeAccount in options #857

Closed
radiofrequency opened this issue Apr 2, 2020 · 8 comments · Fixed by #1102
Closed

Feature Request: Allow initializing the stripeAccount in options #857

radiofrequency opened this issue Apr 2, 2020 · 8 comments · Fixed by #1102
Assignees
@richardm-stripe

Comments

@radiofrequency
Copy link

Currently stripeAccount needs to be specified for each request. Allow setting stripeAccount in the initial options or provide ability to customize the http headers of all requests.
@remi-stripe
Copy link
Contributor

Thanks for the report @radiofrequency! We'll look into what that could look like!

@lyndonbuckley
Copy link
Contributor

@richardm-stripe @remi-stripe
Has there been any progress on this?
Would you be willing to accept a pull request?

lyndonbuckley pushed a commit to lyndonbuckley/stripe-node that referenced this issue Jan 1, 2021
stripe#857 add default option for stripeAccount
f6e146e
lyndonbuckley added a commit to lyndonbuckley/stripe-node that referenced this issue Jan 1, 2021
@lyndonbuckley
Merge pull request #1 from lyndonbuckley/lyndonbuckley-stripeaccount-…
927f248 
…option

stripe#857 add default option for stripeAccount
@lyndonbuckley lyndonbuckley mentioned this issue Jan 1, 2021
Merged
@lyndonbuckley
Copy link
Contributor

#1102

@lyndonbuckley
Copy link
Contributor

Hi @richardm-stripe @remi-stripe
Just wondering if you've had time to review the submitted pull request?

@remi-stripe
Copy link
Contributor

@lyndonbuckley Sorry for delays here, looks like this one slipped through the cracks but we'll have a look this week!

@lyndonbuckley
Copy link
Contributor

@remi-stripe any update on this?

@remi-stripe
Copy link
Contributor

Really sorry for the delay @lyndonbuckley. I'll do my best to get this reviewed this week!

richardm-stripe pushed a commit that referenced this issue Jul 13, 2021
@richardm-stripe
#857 add default option for stripeAccount
8e13836
richardm-stripe pushed a commit that referenced this issue Jul 15, 2021
@lyndonbuckley
#857 add default option for stripeAccount (#1102)
40eaaab 
Co-authored-by: lyndonbuckley <[email protected]>
@richardm-stripe
Copy link
Contributor

richardm-stripe commented Jul 20, 2021 •
edited
Loading

Fixed in #1102, released in v8.163.0. Huge thank you to
@lyndonbuckley for implementing and @radiofrequency for suggesting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@richardm-stripe richardm-stripe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#857 Allow default stripeAccount in options lyndonbuckley/stripe-node
4 participants
@radiofrequency @lyndonbuckley @remi-stripe @richardm-stripe