Skip to content

Commit

Permalink
Revert #4174 (#4290)
Browse files Browse the repository at this point in the history
## Summary
- Reverts a changes that causes issues within navigation stacks
- #4175

## Motivation
- ir-enter-pioneer

## Testing
- Manual
- Tests to follow as remediation

## Changelog
See diff
  • Loading branch information
porter-stripe authored Nov 21, 2024
1 parent cfb859a commit a8de4f9
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## x.x.x x-x-x
### PaymentSheet
* [Fixed] A bug where PaymentSheet would cause layout issues when nested within certain navigation stacks.

## 24.0.1 2024-11-18
### PaymentSheet
* [Added] Instant Bank Payments are now available when using deferred intents.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,18 +69,19 @@ class BottomSheetPresentationAnimator: NSObject {

private func animateDismissal(transitionContext: UIViewControllerContextTransitioning) {
guard
let toVC = transitionContext.viewController(forKey: .to),
let fromVC = transitionContext.viewController(forKey: .from)
else { return }

// Calls viewWillAppear and viewWillDisappear
fromVC.beginAppearanceTransition(false, animated: true)
toVC.beginAppearanceTransition(true, animated: true)

Self.animate({
fromVC.view.frame.origin.y = transitionContext.containerView.frame.height
}) { didComplete in
fromVC.view.removeFromSuperview()
// Calls viewDidAppear and viewDidDisappear
fromVC.endAppearanceTransition()
toVC.endAppearanceTransition()
transitionContext.completeTransition(didComplete)
}
}
Expand Down

0 comments on commit a8de4f9

Please sign in to comment.