Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly re-architecture the library to handle various source abstractions #1275

Merged

Conversation

remi-stripe
Copy link
Contributor

@remi-stripe remi-stripe commented Sep 10, 2018

Today, the library has multiple separate classes that "abstract" away the complexity in the API around payment sources and payout destinations.

This is partly described in details in #1066 though it was written before External Accounts existed.

This PR will attempt to rewrite or merge classes so that we end up with only three concepts:

  • ExternalAccount representing the objects where funds can be paid out
  • PaymentSource representing the objects acting as a Source on a Charge
  • Source the existing API resource which would be a subset of PaymentSource

cc @stripe/api-libraries

  • Remove the Stripe prefix from StripeBankAccount and StripeExternalAccount resources
  • A Payout destination should be an ExternalAccount
  • Get rid of CustomerBankAccount and move everything over to StripeBankAccount
  • Add tests for ExternalAccount
  • Remove Recipient-related operations on StripeCardService. Those have almost never been used in a few months and this has been deprecated for over 3 years now.
  • Figure out a way to merge StripeCardCreateOptions and StripeCreditCardOptions. We-re going to punt on this for now until we can support nested options properly (sharing parameter names under a different parent parameter name)

@remi-stripe remi-stripe deleted the remi-fix-source-abstraction branch September 10, 2018 16:23
@remi-stripe remi-stripe restored the remi-fix-source-abstraction branch September 10, 2018 16:23
@remi-stripe remi-stripe reopened this Sep 10, 2018
@remi-stripe remi-stripe changed the title [WIP] Release a major version with multiple large breaking changes Properly re-architecture the library to handle various source abstractions Sep 10, 2018
@remi-stripe remi-stripe merged commit 250f07f into remi-stripe-dotnet-major-version Sep 10, 2018
@ob-stripe ob-stripe mentioned this pull request Sep 21, 2018
32 tasks
@ob-stripe ob-stripe deleted the remi-fix-source-abstraction branch September 28, 2018 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants