Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Bacs UI and add support to PaymentSheet & FlowController. #7642

Merged
merged 4 commits into from
Nov 30, 2023

Conversation

samer-stripe
Copy link
Collaborator

@samer-stripe samer-stripe commented Nov 17, 2023

Summary

Update Bacs UI and add support to PaymentSheet & FlowController.

Note: This only adds support for opening the confirmation modal in PaymentSheet & FlowController. Actual LPM support is being done in #7447.

Motivation

Allows for displaying the required Bacs modal when paying with Bacs.

Testing

  • Added tests
  • Modified tests
  • Manually verified

Copy link
Contributor

github-actions bot commented Nov 17, 2023

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │           compressed           │           uncompressed           
          ├───────────┬───────────┬────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff   │ old       │ new       │ diff     
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼──────────
      dex │   3.6 MiB │   3.6 MiB │ +936 B │   7.8 MiB │   7.8 MiB │ +2.9 KiB 
     arsc │   2.3 MiB │   2.3 MiB │    0 B │   2.3 MiB │   2.3 MiB │      0 B 
 manifest │   5.1 KiB │   5.1 KiB │    0 B │  25.4 KiB │  25.4 KiB │      0 B 
      res │ 905.6 KiB │ 905.6 KiB │    0 B │   1.4 MiB │   1.4 MiB │      0 B 
   native │   2.6 MiB │   2.6 MiB │    0 B │     6 MiB │     6 MiB │      0 B 
    asset │     3 MiB │     3 MiB │  -29 B │     3 MiB │     3 MiB │    -29 B 
    other │ 204.5 KiB │ 204.5 KiB │  -14 B │ 460.3 KiB │ 460.3 KiB │      0 B 
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼──────────
    total │  12.5 MiB │  12.5 MiB │ +893 B │  20.9 MiB │  20.9 MiB │ +2.9 KiB 

 DEX     │ old   │ new   │ diff              
─────────┼───────┼───────┼───────────────────
   files │     1 │     1 │   0               
 strings │ 38599 │ 38576 │ -23 (+60 -83)     
   types │ 12696 │ 12703 │  +7 (+48 -41)     
 classes │ 10678 │ 10684 │  +6 (+12 -6)      
 methods │ 55611 │ 55625 │ +14 (+3672 -3658) 
  fields │ 35789 │ 35784 │  -5 (+2027 -2032) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  292 │  292 │  0   
 entries │ 6937 │ 6937 │  0
APK
    compressed     │     uncompressed     │                                
──────────┬────────┼───────────┬──────────┤                                
 size     │ diff   │ size      │ diff     │ path                           
──────────┼────────┼───────────┼──────────┼────────────────────────────────
  3.6 MiB │ +936 B │   7.8 MiB │ +2.9 KiB │ ∆ classes.dex                  
  6.4 KiB │  -24 B │   6.3 KiB │    -24 B │ ∆ assets/dexopt/baseline.prof  
 65.6 KiB │   -9 B │ 147.1 KiB │      0 B │ ∆ META-INF/CERT.SF             
    766 B │   -5 B │     634 B │     -5 B │ ∆ assets/dexopt/baseline.profm 
 49.8 KiB │   -4 B │ 147.1 KiB │      0 B │ ∆ META-INF/MANIFEST.MF         
  1.2 KiB │   -1 B │   1.2 KiB │      0 B │ ∆ META-INF/CERT.RSA            
──────────┼────────┼───────────┼──────────┼────────────────────────────────
  3.7 MiB │ +893 B │   8.1 MiB │ +2.9 KiB │ (total)
DEX
STRINGS:

   old   │ new   │ diff          
  ───────┼───────┼───────────────
   38599 │ 38576 │ -23 (+60 -83) 
  + Bacs requires the account's name, email, sort code, and account number be provided!
  + BacsMandateData(name=
  + Cannot confirm non-Bacs payment method with Bacs mandate
  + Intent(context, BacsMand…tExtra(EXTRA_ARGS, input)
  + Lff/g;
  + Li3/u;
  + Lsg/s;
  + Lte/a0;
  + Lte/b0;
  + Lte/c0;
  + Lte/v;
  + Lte/w;
  + Lte/x;
  + Lte/y;
  + Lte/z;
  + Lze/w;
  + VLLLLLLLLLLLLLLLLLLLLI
  + VLLLLLLLLLLLLLZLLLLLL
  + [La7/b;
  + [Lff/g;
  + [Lgg/d4;
  + [Lgg/i7;
  + [Lgg/o3;
  + [Lgg/o4;
  + [Lgg/u5;
  + [Lgg/v0;
  + [Lif/a;
  + [Lif/b1;
  + [Lif/c;
  + [Lif/e;
  + [Lif/o1;
  + [Lif/o;
  + [Lif/t;
  + [Lif/w0;
  + [Lif/z;
  + [Ljf/h;
  + [Log/a3;
  + [Log/b2;
  + [Log/t0;
  + [Log/v2;
  + [Log/x0;
  + [Lte/l;
  + [Lte/m;
  + [Lte/n;
  + [Ltg/e1;
  + [Ltg/h3;
  + [Ltg/h4;
  + [Ltg/n2;
  + [Ltg/o1;
  + [Ltg/t3;
  + [Ltg/v1;
  + [Ltg/v3;
  + [Ltg/y0;
  + [Ltg/z1;
  + activityResultCaller.reg…csMandateResult
          )
  + bacsMandateConfirmationLauncherFactory
  + onBacsMandateResult
  + onBacsMandateResult_paymentsheet_release(Lcom/stripe/android/paymentsheet/paymentdatacollection/bacs/BacsMandateConfirmationResult;)V
  + onBacsMandateResult(Lcom/stripe/android/paymentsheet/paymentdatacollection/bacs/BacsMandateConfirmationResult;)V
  + ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:fec6f33,r8-mode:full,version:8.1.65}
  
  - A3
  - B3
  - C3
  - D3
  - E3
  - F3
  - G3
  - Lgg/p7;
  - Lgg/q7;
  - Lif/p1;
  - Log/s4;
  - Ltg/k4;
  - Luf/m;
  - R2
  - S2
  - T2
  - U2
  - V2
  - VLLLLLLLLLLLLLZLLLLL
  - W2
  - X2
  - Y2
  - Z2
  - [La0/p;
  - [Lff/f;
  - [Lgg/f4;
  - [Lgg/k7;
  - [Lgg/q3;
  - [Lgg/q4;
  - [Lgg/w5;
  - [Lgg/x0;
  - [Lif/b;
  - [Lif/c1;
  - [Lif/d;
  - [Lif/f0;
  - [Lif/j;
  - [Lif/p1;
  - [Lif/r;
  - [Lif/x0;
  - [Lif/x;
  - [Ljf/f;
  - [Log/c2;
  - [Log/c3;
  - [Log/u0;
  - [Log/w2;
  - [Log/y0;
  - [Lte/j;
  - [Lte/k;
  - [Ltg/a2;
  - [Ltg/d1;
  - [Ltg/i4;
  - [Ltg/j3;
  - [Ltg/p1;
  - [Ltg/p2;
  - [Ltg/u3;
  - [Ltg/w1;
  - [Ltg/w3;
  - [Ltg/x0;
  - a3
  - b3
  - c3
  - d3
  - e3
  - f3
  - g3
  - i3
  - j3
  - k3
  - l3
  - m3
  - n3
  - o3
  - q3
  - r3
  - s3
  - t3
  - u3
  - v3
  - w3
  - x3
  - y3
  - z3
  - ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:821c950,r8-mode:full,version:8.1.65}
  

TYPES:

   old   │ new   │ diff         
  ───────┼───────┼──────────────
   12696 │ 12703 │ +7 (+48 -41) 
  + Lff/g;
  + Li3/u;
  + Lsg/s;
  + Lte/a0;
  + Lte/b0;
  + Lte/c0;
  + Lte/v;
  + Lte/w;
  + Lte/x;
  + Lte/y;
  + Lte/z;
  + Lze/w;
  + [La7/b;
  + [Lff/g;
  + [Lgg/d4;
  + [Lgg/i7;
  + [Lgg/o3;
  + [Lgg/o4;
  + [Lgg/u5;
  + [Lgg/v0;
  + [Lif/a;
  + [Lif/b1;
  + [Lif/c;
  + [Lif/e;
  + [Lif/o1;
  + [Lif/o;
  + [Lif/t;
  + [Lif/w0;
  + [Lif/z;
  + [Ljf/h;
  + [Log/a3;
  + [Log/b2;
  + [Log/t0;
  + [Log/v2;
  + [Log/x0;
  + [Lte/l;
  + [Lte/m;
  + [Lte/n;
  + [Ltg/e1;
  + [Ltg/h3;
  + [Ltg/h4;
  + [Ltg/n2;
  + [Ltg/o1;
  + [Ltg/t3;
  + [Ltg/v1;
  + [Ltg/v3;
  + [Ltg/y0;
  + [Ltg/z1;
  
  - Lgg/p7;
  - Lgg/q7;
  - Lif/p1;
  - Log/s4;
  - Ltg/k4;
  - Luf/m;
  - [La0/p;
  - [Lff/f;
  - [Lgg/f4;
  - [Lgg/k7;
  - [Lgg/q3;
  - [Lgg/q4;
  - [Lgg/w5;
  - [Lgg/x0;
  - [Lif/b;
  - [Lif/c1;
  - [Lif/d;
  - [Lif/f0;
  - [Lif/j;
  - [Lif/p1;
  - [Lif/r;
  - [Lif/x0;
  - [Lif/x;
  - [Ljf/f;
  - [Log/c2;
  - [Log/c3;
  - [Log/u0;
  - [Log/w2;
  - [Log/y0;
  - [Lte/j;
  - [Lte/k;
  - [Ltg/a2;
  - [Ltg/d1;
  - [Ltg/i4;
  - [Ltg/j3;
  - [Ltg/p1;
  - [Ltg/p2;
  - [Ltg/u3;
  - [Ltg/w1;
  - [Ltg/w3;
  - [Ltg/x0;
  

METHODS:

   old   │ new   │ diff              
  ───────┼───────┼───────────────────
   55611 │ 55625 │ +14 (+3672 -3658) 
  + a0.p A(TypedArray, XmlPullParser, Resources_Theme) → ColorStateList
  + a0.p B(TypedArray, XmlPullParser, Resources_Theme, String, int) → k1
  + a0.p C(TypedArray, XmlPullParser, String, int, float) → float
  + a0.p D(TypedArray, XmlPullParser, String, int, int) → int
  + a0.p E(TypedArray, XmlResourceParser, String, int) → String
  + a0.p F(Activity) → Intent
  + a0.p G(Context, ComponentName) → Intent
  + a0.p H(Context, ComponentName) → String
  + a0.p I(View) → a
  + a0.p J(TypedArray, int, int) → String
  + a0.p K(XmlPullParser, String) → boolean
  + a0.p L(x) → boolean
  + a0.p M(int) → boolean
  + a0.p N(g, b, j) → s
  + a0.p O(int, int, int) → in
...✂

@samer-stripe samer-stripe force-pushed the samer/connect-bacs-modal branch 3 times, most recently from 2505f06 to 82ccb6d Compare November 22, 2023 02:31
@samer-stripe samer-stripe force-pushed the samer/connect-bacs-modal branch 3 times, most recently from 9890d79 to 089b65f Compare November 23, 2023 15:49
@samer-stripe samer-stripe merged commit e54144f into master Nov 30, 2023
10 checks passed
@samer-stripe samer-stripe deleted the samer/connect-bacs-modal branch November 30, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants