-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Bacs
UI and add support to PaymentSheet
& FlowController
.
#7642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samer-stripe
requested review from
ccen-stripe,
tillh-stripe and
jaynewstrom-stripe
November 17, 2023 23:26
samer-stripe
force-pushed
the
samer/connect-bacs-modal
branch
from
November 17, 2023 23:30
353944a
to
31c8c3f
Compare
Diffuse output:
APK
DEX
|
samer-stripe
force-pushed
the
samer/connect-bacs-modal
branch
3 times, most recently
from
November 22, 2023 02:31
2505f06
to
82ccb6d
Compare
...om/stripe/android/paymentsheet/paymentdatacollection/bacs/BacsMandateConfirmationLauncher.kt
Outdated
Show resolved
Hide resolved
...om/stripe/android/paymentsheet/paymentdatacollection/bacs/BacsMandateConfirmationContract.kt
Outdated
Show resolved
Hide resolved
...tripe/android/paymentsheet/paymentdatacollection/bacs/FakeBacsMandateConfirmationLauncher.kt
Outdated
Show resolved
Hide resolved
samer-stripe
force-pushed
the
samer/connect-bacs-modal
branch
3 times, most recently
from
November 23, 2023 15:49
9890d79
to
089b65f
Compare
...rc/main/java/com/stripe/android/paymentsheet/paymentdatacollection/bacs/BacsMandateButton.kt
Show resolved
Hide resolved
paymentsheet/src/main/java/com/stripe/android/paymentsheet/PaymentSheetViewModel.kt
Outdated
Show resolved
Hide resolved
...tripe/android/paymentsheet/paymentdatacollection/bacs/FakeBacsMandateConfirmationLauncher.kt
Outdated
Show resolved
Hide resolved
samer-stripe
force-pushed
the
samer/connect-bacs-modal
branch
from
November 27, 2023 16:33
089b65f
to
98b57fc
Compare
...tsheet/src/main/java/com/stripe/android/paymentsheet/flowcontroller/DefaultFlowController.kt
Outdated
Show resolved
Hide resolved
…n `DefaultFlowController`
jaynewstrom-stripe
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update
Bacs
UI and add support toPaymentSheet
&FlowController
.Note: This only adds support for opening the confirmation modal in
PaymentSheet
&FlowController
. Actual LPM support is being done in #7447.Motivation
Allows for displaying the required
Bacs
modal when paying withBacs
.Testing