-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bacs support. #7447
Merged
Merged
Add Bacs support. #7447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samer-stripe
requested review from
ccen-stripe,
jameswoo-stripe and
jaynewstrom-stripe
and removed request for
ccen-stripe
October 16, 2023 22:13
samer-stripe
commented
Oct 16, 2023
paymentsheet/src/main/java/com/stripe/android/paymentsheet/PaymentSheetViewModel.kt
Outdated
Show resolved
Hide resolved
Diffuse output:
APK
DEX
ARSC
|
samer-stripe
force-pushed
the
samer/bacs-debit-support
branch
from
October 17, 2023 03:03
80fe268
to
f49015b
Compare
samer-stripe
commented
Oct 17, 2023
...nts-ui-core/src/main/java/com/stripe/android/paymentsheet/forms/PaymentMethodRequirements.kt
Show resolved
Hide resolved
samer-stripe
force-pushed
the
samer/bacs-debit-support
branch
from
October 17, 2023 15:45
f49015b
to
427f67a
Compare
...nts-ui-core/src/main/java/com/stripe/android/paymentsheet/forms/PaymentMethodRequirements.kt
Show resolved
Hide resolved
payments-core/src/main/java/com/stripe/android/model/PaymentMethodCreateParams.kt
Outdated
Show resolved
Hide resolved
stripe-ui-core/src/main/java/com/stripe/android/uicore/elements/CheckboxFieldUI.kt
Outdated
Show resolved
Hide resolved
paymentsheet/src/main/java/com/stripe/android/paymentsheet/PaymentSheetViewModel.kt
Outdated
Show resolved
Hide resolved
paymentsheet/src/main/java/com/stripe/android/paymentsheet/PaymentSheetViewModel.kt
Outdated
Show resolved
Hide resolved
Has our designer taken a look at this? Is this new screen the way we want it to look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to update flow controller as well?
samer-stripe
force-pushed
the
samer/bacs-debit-support
branch
from
November 18, 2023 00:14
427f67a
to
f73317a
Compare
samer-stripe
changed the base branch from
master
to
samer/connect-bacs-modal
November 18, 2023 00:15
samer-stripe
force-pushed
the
samer/connect-bacs-modal
branch
from
November 20, 2023 04:27
d7cd262
to
2505f06
Compare
3 tasks
samer-stripe
force-pushed
the
samer/connect-bacs-modal
branch
from
November 22, 2023 02:31
2505f06
to
82ccb6d
Compare
samer-stripe
force-pushed
the
samer/bacs-debit-support
branch
from
November 22, 2023 02:31
f73317a
to
6076e20
Compare
payments-ui-core/src/main/java/com/stripe/android/ui/core/forms/resources/LpmRepository.kt
Outdated
Show resolved
Hide resolved
paymentsheet-example/src/androidTest/java/com/stripe/android/lpm/TestBacs.kt
Show resolved
Hide resolved
samer-stripe
force-pushed
the
samer/connect-bacs-modal
branch
4 times, most recently
from
November 27, 2023 16:33
089b65f
to
98b57fc
Compare
samer-stripe
force-pushed
the
samer/bacs-debit-support
branch
from
November 30, 2023 22:10
6076e20
to
0212a8f
Compare
paymentsheet/src/main/java/com/stripe/android/paymentsheet/forms/FormViewModel.kt
Outdated
Show resolved
Hide resolved
samer-stripe
force-pushed
the
samer/bacs-debit-support
branch
from
December 5, 2023 19:11
0212a8f
to
a67bbca
Compare
samer-stripe
force-pushed
the
samer/bacs-debit-support
branch
2 times, most recently
from
December 15, 2023 23:27
f79a385
to
c947e33
Compare
samer-stripe
force-pushed
the
samer/bacs-debit-support
branch
from
December 15, 2023 23:30
c947e33
to
6168163
Compare
jaynewstrom-stripe
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds Bacs support for the Android SDK by connecting all the LUXE and confirmation form pieces together and enabling it in the
LpmRepository
.Motivation
Adds another payment method that can be used within the SDK.
Testing
Video
BacsOnAndroid.webm