Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bacs support. #7447

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Add Bacs support. #7447

merged 1 commit into from
Dec 19, 2023

Conversation

samer-stripe
Copy link
Collaborator

@samer-stripe samer-stripe commented Oct 16, 2023

Summary

Adds Bacs support for the Android SDK by connecting all the LUXE and confirmation form pieces together and enabling it in the LpmRepository.

Motivation

Adds another payment method that can be used within the SDK.

Testing

  • Added tests
  • Modified tests
  • Manually verified

Video

BacsOnAndroid.webm

@samer-stripe samer-stripe requested review from a team as code owners October 16, 2023 22:13
@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2023

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │           compressed           │           uncompressed           
          ├───────────┬───────────┬────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff   │ old       │ new       │ diff     
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼──────────
      dex │   3.6 MiB │   3.6 MiB │ +296 B │   7.8 MiB │   7.8 MiB │   +1 KiB 
     arsc │   2.3 MiB │   2.3 MiB │ +592 B │   2.3 MiB │   2.3 MiB │   +592 B 
 manifest │   5.1 KiB │   5.1 KiB │    0 B │  25.4 KiB │  25.4 KiB │      0 B 
      res │ 922.9 KiB │ 922.9 KiB │    0 B │   1.4 MiB │   1.4 MiB │      0 B 
   native │   2.6 MiB │   2.6 MiB │    0 B │     6 MiB │     6 MiB │      0 B 
    asset │     3 MiB │     3 MiB │   +4 B │     3 MiB │     3 MiB │    +69 B 
    other │ 205.3 KiB │ 205.3 KiB │   +2 B │ 462.1 KiB │ 462.1 KiB │      0 B 
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼──────────
    total │  12.5 MiB │  12.5 MiB │ +894 B │  20.9 MiB │  20.9 MiB │ +1.7 KiB 

 DEX     │ old   │ new   │ diff       
─────────┼───────┼───────┼────────────
   files │     1 │     1 │  0         
 strings │ 38806 │ 38808 │ +2 (+3 -1) 
   types │ 12993 │ 12993 │  0 (+0 -0) 
 classes │ 10977 │ 10977 │  0 (+0 -0) 
 methods │ 53954 │ 53957 │ +3 (+5 -2) 
  fields │ 35910 │ 35915 │ +5 (+6 -1) 

 ARSC    │ old  │ new  │ diff       
─────────┼──────┼──────┼────────────
 configs │  292 │  292 │  0         
 entries │ 6939 │ 6940 │ +1 (+1 -0)
APK
    compressed     │     uncompressed     │                               
──────────┬────────┼───────────┬──────────┤                               
 size     │ diff   │ size      │ diff     │ path                          
──────────┼────────┼───────────┼──────────┼───────────────────────────────
  2.3 MiB │ +592 B │   2.3 MiB │   +592 B │ ∆ resources.arsc              
  3.6 MiB │ +296 B │   7.8 MiB │   +1 KiB │ ∆ classes.dex                 
  3.1 KiB │   +6 B │  25.3 KiB │    +71 B │ ∆ assets/lpms.json            
   66 KiB │   +3 B │   148 KiB │      0 B │ ∆ META-INF/CERT.SF            
  6.7 KiB │   -2 B │   6.6 KiB │     -2 B │ ∆ assets/dexopt/baseline.prof 
 50.2 KiB │   -2 B │ 147.9 KiB │      0 B │ ∆ META-INF/MANIFEST.MF        
    950 B │   -1 B │   2.5 KiB │      0 B │ ∆ res/de.xml                  
  1.1 KiB │   +1 B │   3.2 KiB │      0 B │ ∆ res/nn.xml                  
  1.2 KiB │   +1 B │   1.2 KiB │      0 B │ ∆ META-INF/CERT.RSA           
──────────┼────────┼───────────┼──────────┼───────────────────────────────
    6 MiB │ +894 B │  10.3 MiB │ +1.7 KiB │ (total)
DEX
STRINGS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   38806 │ 38808 │ +2 (+3 -1) 
  + accountNumberIdentifier
  + sortCodeIdentifier
  + ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:3c5522f,r8-mode:full,version:8.2.33}
  
  - ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:eb8dc6e,r8-mode:full,version:8.2.33}
  

METHODS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   53954 │ 53957 │ +3 (+5 -2) 
  + ig.a6 <init>(b1, z5)
  + ig.w <init>()
  + ig.w <init>(int, b1, b1, b1)
  + ig.z <init>()
  + qg.x <init>(v, boolean)
  
  - ig.w <init>(int, b1)
  - qg.x <init>(v)
  

FIELDS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   35910 │ 35915 │ +5 (+6 -1) 
  + ig.w b: b1
  + ig.w c: b1
  + ig.w d: int
  + oe.v D: u
  + qg.b1 n0: b1
  + qg.b1 o0: b[]
  
  - qg.b1 n0: b[]
ARSC
ENTRIES:

   old  │ new  │ diff       
  ──────┼──────┼────────────
   6939 │ 6940 │ +1 (+1 -0) 
  + string/stripe_paymentsheet_payment_method_bacs_debit

@samer-stripe samer-stripe force-pushed the samer/bacs-debit-support branch from 80fe268 to f49015b Compare October 17, 2023 03:03
@samer-stripe samer-stripe force-pushed the samer/bacs-debit-support branch from f49015b to 427f67a Compare October 17, 2023 15:45
@jameswoo-stripe
Copy link
Contributor

Has our designer taken a look at this? Is this new screen the way we want it to look?

Copy link
Contributor

@jameswoo-stripe jameswoo-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update flow controller as well?

@samer-stripe samer-stripe force-pushed the samer/bacs-debit-support branch from 427f67a to f73317a Compare November 18, 2023 00:14
@samer-stripe samer-stripe changed the base branch from master to samer/connect-bacs-modal November 18, 2023 00:15
@samer-stripe samer-stripe force-pushed the samer/connect-bacs-modal branch from d7cd262 to 2505f06 Compare November 20, 2023 04:27
@samer-stripe samer-stripe force-pushed the samer/connect-bacs-modal branch from 2505f06 to 82ccb6d Compare November 22, 2023 02:31
@samer-stripe samer-stripe force-pushed the samer/bacs-debit-support branch from f73317a to 6076e20 Compare November 22, 2023 02:31
@samer-stripe samer-stripe force-pushed the samer/connect-bacs-modal branch 4 times, most recently from 089b65f to 98b57fc Compare November 27, 2023 16:33
Base automatically changed from samer/connect-bacs-modal to master November 30, 2023 18:11
@samer-stripe samer-stripe force-pushed the samer/bacs-debit-support branch from 6076e20 to 0212a8f Compare November 30, 2023 22:10
@samer-stripe samer-stripe force-pushed the samer/bacs-debit-support branch from 0212a8f to a67bbca Compare December 5, 2023 19:11
@samer-stripe samer-stripe force-pushed the samer/bacs-debit-support branch 2 times, most recently from f79a385 to c947e33 Compare December 15, 2023 23:27
@samer-stripe samer-stripe force-pushed the samer/bacs-debit-support branch from c947e33 to 6168163 Compare December 15, 2023 23:30
@samer-stripe samer-stripe merged commit 10d927f into master Dec 19, 2023
11 checks passed
@samer-stripe samer-stripe deleted the samer/bacs-debit-support branch December 19, 2023 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants