-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use activity instead of fragment for cardscan #6253
Merged
awush-stripe
merged 3 commits into
master
from
awush/RUN_INTERVENTIONS-9/use_activity_instead_of_fragment_for_cardscan
Feb 23, 2023
Merged
Use activity instead of fragment for cardscan #6253
awush-stripe
merged 3 commits into
master
from
awush/RUN_INTERVENTIONS-9/use_activity_instead_of_fragment_for_cardscan
Feb 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaynewstrom-stripe
previously approved these changes
Feb 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to see before/after if it looks different.
Do we need release notes?
Diffuse output:
APK
DEX
|
Good call! I've updated the CHANGELOG. I'll add a before + after momentarily |
jaynewstrom-stripe
approved these changes
Feb 23, 2023
awush-stripe
deleted the
awush/RUN_INTERVENTIONS-9/use_activity_instead_of_fragment_for_cardscan
branch
February 23, 2023 18:39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The cardscan fragment is causing crashes on the stripe payment sheets page. Replace the fragment with the full-screen scan, which should not have the same camera error issues.
Motivation
#6116
Testing
Screenshots