Use activity instead of fragment for cardscan (#6253)

* Use the cardscan activity in payment sheet

* Remove commented-out code

* Update changelog

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ## XX.XX.XX - 2023-XX-XX
 
+### StripeCardScan
+[FIXED][6253](https://github.com/stripe/stripe-android/pull/6253) Use the full screen card scanner to alleviate fragment crashes
 
 ## 20.19.3 - 2023-02-13
 

payments-ui-core/src/main/java/com/stripe/android/ui/core/cardscan/CardScanActivity.kt

@@ -5,7 +5,6 @@ import android.os.Bundle
 import androidx.appcompat.app.AppCompatActivity
 import com.stripe.android.PaymentConfiguration
 import com.stripe.android.stripecardscan.cardscan.CardScanSheetResult
-import com.stripe.android.ui.core.R
 import com.stripe.android.ui.core.StripeCardScanProxy
 import com.stripe.android.ui.core.databinding.ActivityCardScanBinding
 
@@ -25,16 +24,7 @@ internal class CardScanActivity : AppCompatActivity() {
             PaymentConfiguration.getInstance(this).publishableKey,
             this::onScanFinished
         )
-    }
-
-    override fun onStart() {
-        super.onStart()
-        stripeCardScanProxy.attachCardScanFragment(
-            this,
-            supportFragmentManager,
-            R.id.fragment_container,
-            this::onScanFinished
-        )
+        stripeCardScanProxy.present()
     }
 
     private fun onScanFinished(result: CardScanSheetResult) {
@@ -47,11 +37,6 @@ internal class CardScanActivity : AppCompatActivity() {
         finish()
     }
 
-    override fun onStop() {
-        StripeCardScanProxy.removeCardScanFragment(supportFragmentManager)
-        super.onStop()
-    }
-
     companion object {
         const val CARD_SCAN_PARCELABLE_NAME = "CardScanActivityResult"
     }