Get completion loop frame count from initialize client #5679
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,77 +13,70 @@ internal enum class ImageFormat(val string: String) { | |
| companion object { | ||
| fun fromValue(value: CardImageVerificationDetailsFormat): ImageFormat = | ||
| when (value) { | ||
| CardImageVerificationDetailsFormat.HEIC -> HEIC | ||
| CardImageVerificationDetailsFormat.JPEG -> JPEG | ||
| CardImageVerificationDetailsFormat.WEBP -> WEBP | ||
| } | ||
| } | ||
| } | ||
|
|
||
| internal data class OptionalImageSettings( | ||
| val compressionRatio: Double?, | ||
| val imageSize: Size?, | ||
| val imageCount: Int? | ||
| ) { | ||
| constructor(settings: CardImageVerificationDetailsImageSettings?) : this( | ||
| compressionRatio = settings?.compressionRatio, | ||
| imageSize = settings?.imageSize?.takeIf { it.size > 1 }?.let { | ||
| Size(it.first().toInt(), it.last().toInt()) | ||
| }, | ||
| imageCount = settings?.imageCount | ||
| ) | ||
| } | ||
|
|
||
| internal data class ImageSettings( | ||
| val compressionRatio: Double, | ||
| val imageSize: Size, | ||
| val imageCount: Int | ||
|
Comment on lines
+38
to
+40
There was a problem hiding this comment. prefer immutability |
||
| ) { | ||
| companion object { | ||
| // These default values are what Android was using before the addition of a server config. | ||
| val DEFAULT = ImageSettings(0.92, Size(1080, 1920), 3) | ||
|
There was a problem hiding this comment. @jaimepark-stripe these are the default values |
||
| } | ||
| } | ||
|
|
||
| internal data class AcceptedImageConfigs( | ||
| private val defaultSettings: OptionalImageSettings?, | ||
| private val formatSettings: Map<ImageFormat, OptionalImageSettings?>? = null, | ||
| val preferredFormats: List<ImageFormat>? = listOf(ImageFormat.JPEG) | ||
| ) { | ||
| companion object { | ||
| internal fun isFormatSupported(format: ImageFormat) = | ||
| format == ImageFormat.JPEG || format == ImageFormat.WEBP | ||
| } | ||
|
|
||
| constructor(configs: CardImageVerificationDetailsAcceptedImageConfigs? = null) : this( | ||
| defaultSettings = configs?.defaultSettings?.let { OptionalImageSettings(it) }, | ||
| formatSettings = configs?.formatSettings?.takeIf { it.isNotEmpty() }?.map { entry -> | ||
| ImageFormat.fromValue(entry.key) to OptionalImageSettings(entry.value) | ||
| } | ||
| ?.toMap(), | ||
| preferredFormats = configs?.preferredFormats?.map { ImageFormat.fromValue(it) } | ||
| ?.filter { isFormatSupported(it) } | ||
| ?.takeIf { it.isNotEmpty() } | ||
| ) | ||
|
|
||
| fun getImageSettings(format: ImageFormat): ImageSettings = ImageSettings( | ||
| compressionRatio = formatSettings?.get(format)?.compressionRatio | ||
| ?: defaultSettings?.compressionRatio ?: ImageSettings.DEFAULT.compressionRatio, | ||
| imageSize = formatSettings?.get(format)?.imageSize ?: defaultSettings?.imageSize | ||
| ?: ImageSettings.DEFAULT.imageSize, | ||
| imageCount = formatSettings?.get(format)?.imageCount ?: defaultSettings?.imageCount | ||
| ?: ImageSettings.DEFAULT.imageCount | ||
| ) | ||
|
|
||
| fun getImageSettings(): Pair<ImageFormat, ImageSettings> { | ||
| val format = preferredFormats?.first() ?: ImageFormat.JPEG | ||
| return format to getImageSettings(format) | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.