Get completion loop frame count from initialize client #5679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awush-stripe
commented
Oct 6, 2022
Comment on lines
+38
to
+40
| val compressionRatio: Double, | ||
| val imageSize: Size, | ||
| val imageCount: Int |
There was a problem hiding this comment.
prefer immutability
awush-stripe
commented
Oct 6, 2022
| imageSize = Size(width, height) | ||
| } | ||
| } | ||
| val DEFAULT = ImageSettings(0.92, Size(1080, 1920), 3) |
There was a problem hiding this comment.
@jaimepark-stripe these are the default values
jaimepark-stripe
approved these changes
Oct 6, 2022
|
@awush-stripe do we want to merge this if we decide the lower compression ratio is good enough? |
|
discussed offline, we'll still merge this. |
awush-stripe
deleted the
awush/get_completion_loop_frame_count_from_initialize_client
branch
jgundy1985
approved these changes
Oct 13, 2022
| @@ -4,8 +4,7 @@ import android.util.Size | |||
| import androidx.test.filters.SmallTest | |||
| import com.stripe.android.stripecardscan.framework.util.AcceptedImageConfigs | |||
| import com.stripe.android.stripecardscan.framework.util.ImageFormat | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Get the completion loop frame count for CIV from the call to initialize_client
Motivation
We've been seeing elevated 4xx errors due to verification payloads being too large. This reduces the number of images sent.
Testing