Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PaymentMethod.Card.networks field public #5552

Merged
merged 3 commits into from
Sep 14, 2022
Merged

Make PaymentMethod.Card.networks field public #5552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bc82b8e
Make PaymentMethod networks prop public
tillh-stripe Sep 14, 2022
fc7d83b
Update API
tillh-stripe Sep 14, 2022
db16004
Update changelog
tillh-stripe Sep 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## X.X.X - 2022-XX-XX

### Payments

* [CHANGED] [5552](https://github.com/stripe/stripe-android/pull/5552) Make `PaymentMethod.Card.networks` field public.

## 20.12.0 - 2022-09-13
This release upgrades `compileSdkVersion` to 33, updates Google Pay button to match the new brand
guidelines and fixes some bugs in `FlowController`.
Expand Down
2 changes: 2 additions & 0 deletions payments-core/api/payments-core.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3567,10 +3567,12 @@ public final class com/stripe/android/model/PaymentMethod$Card : com/stripe/andr
public final field fingerprint Ljava/lang/String;
public final field funding Ljava/lang/String;
public final field last4 Ljava/lang/String;
public final field networks Lcom/stripe/android/model/PaymentMethod$Card$Networks;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this go into the release notes?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so, is this work being done on iOS?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let's add to the CHANGEDOC.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jameswoo-stripe It’s already public in the iOS repo.

public final field threeDSecureUsage Lcom/stripe/android/model/PaymentMethod$Card$ThreeDSecureUsage;
public final field wallet Lcom/stripe/android/model/wallets/Wallet;
public final fun component1 ()Lcom/stripe/android/model/CardBrand;
public final fun component10 ()Lcom/stripe/android/model/wallets/Wallet;
public final fun component11 ()Lcom/stripe/android/model/PaymentMethod$Card$Networks;
public final fun component2 ()Lcom/stripe/android/model/PaymentMethod$Card$Checks;
public final fun component3 ()Ljava/lang/String;
public final fun component4 ()Ljava/lang/Integer;
Expand Down
2 changes: 1 addition & 1 deletion payments-core/src/main/java/com/stripe/android/model/PaymentMethod.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -677,7 +677,7 @@ constructor(
@JvmField val wallet: Wallet? = null,

@JvmField
internal val networks: Networks? = null
val networks: Networks? = null
) : TypeData() {
override val type: Type get() = Type.Card

Expand Down